Skip to content

Rejected URL strings case sensitive, created cache directory lowercase #43206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsaric-dev opened this issue Apr 23, 2025 · 1 comment
Open
Labels
[Experiment] AI labels added [Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Normal [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dsaric-dev
Copy link

Impacted plugin

Super Cache

Quick summary

WP Super Cache has "Rejected URL strings" feature, and the description for it is:
Add here strings (not a filename) that forces a page not to be cached. For example, if your URLs include year and you dont want to cache last year posts, it’s enough to specify the year, i.e. ’/2004/’. WP-Cache will search if that string is part of the URI and if so, it will not cache that page.

The problem with this is that it is case sensitive, and created cache directory is lowercased - this makes this feature far less useful (and arguably problematic), because it becomes super easy to bypass it.
For example, adding a string like a "register" in it prevents WPSC from caching domain.com/register/ - however, if someone accesses domain.com/Register/, WPSC will create /register/ cache version.

I think this should be changed to either lowercase all entered reject strings (which makes sense, as WPSC explicitly lowercases created cache directory), or at least changing the description to warn users of this issue.

Steps to reproduce

  1. Enter any lowercase string (example) in Rejected URL strings
  2. Visit uppercased version of the string, example: domain.com/EXAMPLE/

domain.com/example/ is now cached, I would not have expected this.

Site owner impact

More than 60% of the total website/platform users

Severity

Major

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform (Simple and/or Atomic)

No response

@dsaric-dev dsaric-dev added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Apr 23, 2025
@github-actions github-actions bot added [Plugin] Super Cache A fast caching plugin for WordPress. [Pri] BLOCKER [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Performance History [Feature] WP Super Cache labels Apr 23, 2025
Copy link
Contributor

OpenAI suggested the following labels for this issue:

  • [Feature Group] Content Management: The issue relates to managing cache settings and URL rejection in the Super Cache plugin.
  • [Feature] WP Super Cache: The issue directly pertains to the functionality of the WP Super Cache plugin.
  • [Feature] Performance History: The case sensitivity issue impacts caching performance, which is a key regional aspect of site performance management.

@matticbot matticbot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Apr 23, 2025
@jeherve jeherve added [Pri] Normal Triaged and removed [Pri] BLOCKER Needs triage Ticket needs to be triaged [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Performance History [Feature] WP Super Cache labels Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Normal [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

3 participants