Skip to content

chore: made Account.signTransaction returns TransactionRequest #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented May 27, 2025

Release notes

In this release, we:

  • Made Account.signTransaction returns TransactionRequest or string

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this May 27, 2025
Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 0:32am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 0:32am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 0:32am

Copy link
Contributor

github-actions bot commented May 27, 2025

Temporary PR

This PR is published in AWS CodeArtifact with version: next

Install using the below commands — create-fuels variations are commented out.

PNPM

pnpm config set registry https://npm-packages.fuel.network/ --global
pnpm install fuels@next
# pnpm create fuels@next

NPM

npm --registry=https://npm-packages.fuel.network/ install fuels@next
# npm --registry=https://npm-packages.fuel.network/ create fuels@next

Bun

npm_config_registry=https://npm-packages.fuel.network/ bun install fuels@next
# npm_config_registry=https://npm-packages.fuel.network/ bun create fuels@next

@Torres-ssf Torres-ssf changed the title chore!: made Account.signTransaction returns TransactionRequest chore: made Account.signTransaction returns TransactionRequest May 29, 2025
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.07%(-0.01%) 70.06%(+0.04%) 75.44%(+0.01%) 77.08%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 80.68%
(-0.4%)
69.6%
(-0.69%)
84.74%
(+0.26%)
80.59%
(-0.39%)
🔴 packages/account/src/providers/resource-cache.ts 97.95%
(+0%)
95%
(+5%)
100%
(+0%)
97.95%
(+0%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 90%
(+0%)
82.35%
(+1.18%)
86.27%
(+0%)
90.19%
(+0%)

@Torres-ssf Torres-ssf marked this pull request as ready for review May 29, 2025 16:44
@Torres-ssf Torres-ssf merged commit 52dfa5b into master May 29, 2025
35 of 40 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/type-overload-account-sing-transaction branch May 29, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Connectors signTransaction Method Return TransactionRequest
2 participants