Skip to content

Skip processing of impl self traits for overlap trait coherence checks. #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Skip processing of impl self traits for overlap trait coherence checks. #7192

wants to merge 3 commits into from

Conversation

tritao
Copy link
Contributor

@tritao tritao commented May 22, 2025

Description

Fixes #7187.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao self-assigned this May 22, 2025
@tritao tritao added bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels May 22, 2025
@tritao tritao temporarily deployed to fuel-sway-bot May 22, 2025 18:49 — with GitHub Actions Inactive
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #7192 will not alter performance

Comparing tritao:trait-coherence-fix-impl-self (dfd7fff) with master (f03d5ec)

Summary

✅ 24 untouched benchmarks

@tritao tritao force-pushed the trait-coherence-fix-impl-self branch from 649cb1b to dfd7fff Compare May 27, 2025 20:01
@tritao tritao temporarily deployed to fuel-sway-bot May 27, 2025 20:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tritao tritao

Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trait Coherence compile error with Mira
1 participant
@tritao