Skip to content

Commit 2a329ad

Browse files
committed
Fix purposeful invalid UTF-8 test when running in NodeJS v0.10.42+.
1 parent e4a513d commit 2a329ad

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

circle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ machine:
1414
# don't conflict with our embedded ruby installation.
1515
- rvm reset
1616
node:
17-
version: 0.10.40
17+
version: 0.10.45
1818
dependencies:
1919
cache_directories:
2020
- build/work

test/integration/logging.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -839,7 +839,13 @@ describe('logging', function() {
839839
var expectedRawBinary = new Buffer('77+9', 'base64').toString();
840840

841841
var args = 'url_encoded=' + urlEncoded + '&base64ed=' + base64ed + '&raw=' + raw;
842-
request({
842+
843+
// Use curl and not request for this test, since node's HTTP parser
844+
// prevents invalid utf8 characters from being used in headers as of NodeJS
845+
// v0.10.42. But we still want to test this, since other clients can still
846+
// pass invalid utf8 characters.
847+
var curl = new Curler();
848+
curl.request({
843849
method: 'GET',
844850
url: 'http://localhost:9080/info/' + urlEncoded + '/' + base64ed + '/' + raw + '/?api_key=' + this.apiKey + '&unique_query_id=' + this.uniqueQueryId + '&' + args,
845851
headers: {

0 commit comments

Comments
 (0)