Skip to content

Issue on page /404.html #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaladinB4 opened this issue Apr 1, 2025 · 5 comments
Open

Issue on page /404.html #1123

KaladinB4 opened this issue Apr 1, 2025 · 5 comments

Comments

@KaladinB4
Copy link

Your issue content here. page 404 page not found

@fricklerhandwerk
Copy link
Collaborator

Where did you find this link? That would help identifying the cause of the problem.

As is, this can't possibly work because it's trying to access 2.27 release notes from the 2.24 manual.

@sandydoo
Copy link
Contributor

@fricklerhandwerk, nixos.org has a link to the release notes defined as:

const NIX_VERSION = import.meta.env.NIX_STABLE_VERSION;
const NIX_VERSION_SANITIZED = NIX_VERSION.split('.').slice(0, -1).join('.');
export const NIX_RELEASE_NOTES_LINK = `/manual/nix/stable/release-notes/rl-${NIX_VERSION_SANITIZED}`;

That then redirects to nix.dev:

https://nix.dev/manual/nix/stable/release-notes/rl-2.27

And finally to this:

/manual/nix/2.24/release-notes/rl-2.27

The issue is that nix.dev is using a pinned version of stable nixpkgs to figure out how to resolve stable and that pin is set to 24.11.

It looks like @Mic92 is already on it: #1144

@fricklerhandwerk
Copy link
Collaborator

fricklerhandwerk commented May 27, 2025

Ah but we can fix that much more easily by adding a redirect nix/manual/stable/release-notes/stable to the correct version, and then just bump Nixpkgs and remove the logic from nixos.org.

@Mic92
Copy link
Member

Mic92 commented May 27, 2025

Updating to 25.05 didn't seem to haqve fixed the issue.

@sandydoo
Copy link
Contributor

Updating to 25.05 didn't seem to haqve fixed the issue.

Yeah, the stable manual on nix.dev is now 2.28, but the latest stable nix version according to nixos.org is 2.29.

Ah but we can fix that much more easily by adding a redirect nix/manual/stable/release-notes/stable to the correct version, and then just bump Nixpkgs and remove the logic from nixos.org.

That would work. Otherwise you'll just keep running into issues syncing the two.

One thing to keep in mind is that nixos.org displays the current version in the downloads header. Right now that version is 2.29. So if you click release notes, it might be strange to get redirected to an older version that will get progressively out of date as the stable release ages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants