chore: deprecates dbWatchers and set default value to false (#35981)

Co-authored-by: Diego Sampaio <[email protected]>

Author: ggazzo

.changeset/cuddly-feet-clap.md

@@ -0,0 +1,10 @@
+---
+"@rocket.chat/meteor": patch
+"@rocket.chat/models": patch
+---
+
+Deprecates the use of MongoDB oplog or Change Streams to receive real time data updates.
+
+The previous behavior can still be enabled using the environment flag `DISABLE_DB_WATCHERS=false`.
+
+⚠️ In future major versions, this flag will be completely removed, and the `@rocket.chat/stream-hub-service` package and the `stream-hub-service` Docker image will no longer be published.

.github/workflows/ci-test-e2e.yml

@@ -86,7 +86,7 @@ jobs:
         mongodb-version: ${{ fromJSON(inputs.mongodb-version) }}
         shard: ${{ fromJSON(inputs.shard) }}
 
-    name: MongoDB ${{ matrix.mongodb-version }}${{ inputs.db-watcher-disabled == 'true' && ' [no watchers]' || '' }} (${{ matrix.shard }}/${{ inputs.total-shard }}) - ${{ (matrix.mongodb-version == '7.0' && 'Debian' && false) || 'Alpine (Official)' }}
+    name: MongoDB ${{ matrix.mongodb-version }}${{ inputs.db-watcher-disabled == 'false' && ' [legacy watchers]' || '' }} (${{ matrix.shard }}/${{ inputs.total-shard }}) - ${{ (matrix.mongodb-version == '7.0' && 'Debian' && false) || 'Alpine (Official)' }}
 
     steps:
       - name: Collect Workflow Telemetry

.github/workflows/ci.yml

@@ -531,7 +531,7 @@ jobs:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
       REPORTER_JIRA_ROCKETCHAT_API_KEY: ${{ secrets.REPORTER_JIRA_ROCKETCHAT_API_KEY }}
 
-  test-ui-ee-no-watcher:
+  test-ui-ee-watcher:
     name: 🔨 Test UI (EE)
     needs: [checks, build-gh-docker-coverage, release-versions]
 
@@ -551,7 +551,7 @@ jobs:
       rc-docker-tag: ${{ needs.release-versions.outputs.rc-docker-tag }}
       gh-docker-tag: ${{ needs.release-versions.outputs.gh-docker-tag }}
       retries: ${{ (github.event_name == 'release' || github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/master') && 2 || 0 }}
-      db-watcher-disabled: 'true'
+      db-watcher-disabled: 'false'
     secrets:
       CR_USER: ${{ secrets.CR_USER }}
       CR_PAT: ${{ secrets.CR_PAT }}
@@ -564,7 +564,7 @@ jobs:
   tests-done:
     name: ✅ Tests Done
     runs-on: ubuntu-24.04
-    needs: [checks, test-unit, test-api, test-ui, test-api-ee, test-ui-ee, test-ui-ee-no-watcher]
+    needs: [checks, test-unit, test-api, test-ui, test-api-ee, test-ui-ee, test-ui-ee-watcher]
     if: always()
     steps:
       - name: Test finish aggregation
@@ -593,7 +593,7 @@ jobs:
             exit 1
           fi
 
-          if [[ '${{ needs.test-ui-ee-no-watcher.result }}' != 'success' ]]; then
+          if [[ '${{ needs.test-ui-ee-watcher.result }}' != 'success' ]]; then
             exit 1
           fi
 

packages/models/src/index.ts

@@ -125,9 +125,7 @@ export function getCollectionName(name: string): string {
 
 const disabledEnvVar = String(process.env.DISABLE_DB_WATCHERS).toLowerCase();
 
-export const dbWatchersDisabled =
-	(process.env.NODE_ENV === 'production' && ['yes', 'true'].includes(disabledEnvVar)) ||
-	(process.env.NODE_ENV !== 'production' && !['no', 'false'].includes(disabledEnvVar));
+export const dbWatchersDisabled = !['no', 'false'].includes(disabledEnvVar);
 
 export * from './modelClasses';
 export * from './DatabaseWatcher';
@@ -257,3 +255,9 @@ export function registerServiceModels(db: Db, trash?: Collection<RocketChatRecor
 	registerModel('IUploadsModel', () => new UploadsRaw(db));
 	registerModel('ILivechatVisitorsModel', () => new LivechatVisitorsRaw(db));
 }
+
+if (!dbWatchersDisabled) {
+	console.warn(
+		`Database watchers is enabled and this is not the default option.\nRocket.Chat deprecated the usage of \`oplog/change streams\` and are going to remove it the next major version (8.0.0).`,
+	);
+}