fix: remove apps-engine dependency on internal package (#36007)

Author: d-gubert

.changeset/stale-walls-move.md

@@ -0,0 +1,6 @@
+---
+'@rocket.chat/apps-engine': patch
+'@rocket.chat/meteor': patch
+---
+
+Fixes the Apps-Engine package installation, removing the dependency on an internal package

apps/meteor/ee/server/apps/storage/AppRealStorage.ts

@@ -1,6 +1,7 @@
 import type { IAppStorageItem } from '@rocket.chat/apps-engine/server/storage';
 import { AppMetadataStorage } from '@rocket.chat/apps-engine/server/storage';
 import type { Apps } from '@rocket.chat/models';
+import { removeEmpty } from '@rocket.chat/tools';
 import type { UpdateFilter } from 'mongodb';
 
 export class AppRealStorage extends AppMetadataStorage {
@@ -18,10 +19,11 @@ export class AppRealStorage extends AppMetadataStorage {
 			throw new Error('App already exists.');
 		}
 
-		const id = (await this.db.insertOne(item)).insertedId as unknown as string;
-		item._id = id;
+		const nonEmptyItem = removeEmpty(item);
+		const id = (await this.db.insertOne(nonEmptyItem)).insertedId as unknown as string;
+		nonEmptyItem._id = id;
 
-		return item;
+		return nonEmptyItem;
 	}
 
 	public async retrieveOne(id: string): Promise<IAppStorageItem> {

packages/apps-engine/package.json

@@ -93,7 +93,6 @@
     },
     "dependencies": {
         "@msgpack/msgpack": "3.0.0-beta2",
-        "@rocket.chat/tools": "workspace:^",
         "adm-zip": "^0.5.16",
         "debug": "^4.3.7",
         "esbuild": "^0.25.0",

packages/apps-engine/src/server/AppManager.ts

@@ -1,7 +1,5 @@
 import { Buffer } from 'buffer';
 
-import { removeEmpty } from '@rocket.chat/tools';
-
 import type { IGetAppsFilter } from './IGetAppsFilter';
 import { ProxiedApp } from './ProxiedApp';
 import type { PersistenceBridge, UserBridge } from './bridges';
@@ -609,7 +607,7 @@ export class AppManager {
         }
 
         descriptor.signature = await this.getSignatureManager().signApp(descriptor);
-        const created = await this.appMetadataStorage.create(removeEmpty(descriptor));
+        const created = await this.appMetadataStorage.create(descriptor);
 
         if (!created) {
             aff.setStorageError('Failed to create the App, the storage did not return it.');

yarn.lock

@@ -7999,7 +7999,6 @@ __metadata:
   dependencies:
     "@msgpack/msgpack": "npm:3.0.0-beta2"
     "@rocket.chat/eslint-config": "workspace:~"
-    "@rocket.chat/tools": "workspace:^"
     "@rocket.chat/ui-kit": "workspace:~"
     "@types/adm-zip": "npm:^0.5.6"
     "@types/debug": "npm:^4.1.12"