spotify: Amend the procedure for blocking Spotify autoupdates #15486
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changes look good. Wait for review from human collaborators. spotify
|
|
I'll fix the failing tests within a couple of days! |
|
/verify |
|
Your changes do not pass checks. spotify
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. spotify
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15471 (and possibly also #12429).
Relates to #10841 and PR #12737
Change 1: Instead of using "read-only" and "system" files attributes (which Spotify doesn't respect) to block the deletion of the file named
Update, theicaclscommand is used to deny delete permissions to the current user for this file. I've verified that Spotify doesn't delete this file on startup anymore.Change 2: The
Remove-Itemcommands have been modified to work without pausing for user input, regardless of whetherUpdateis a file or a directory. Also, all the commands related to autoupdate blocking have been set to not print error messages on failure (to avoids issues like #11216)<manifest-name[@version]|chore>: <general summary of the pull request>