Do we want to support Map/Set in the default query hash function?

[braeden]

query/packages/query-core/src/utils.ts

Lines 180 to 191 in 0a181d5

	export function hashKey(queryKey: QueryKey | MutationKey): string {
	return JSON.stringify(queryKey, (_, val) =>
	isPlainObject(val)
	? Object.keys(val)
	.sort()
	.reduce((result, key) => {
	result[key] = val[key]
	return result
	}, {} as any)
	: val,
	)
	}

Using Map/Set as a query key has some slightly non-intuitive behavior because of the fact that Object.values(new Map([ ['foo', 'bar'] ])) => [].

We could probably fix it with something like this. But I wanted to see what people think about this before I put a PR up.

return JSON.stringify(queryKey, (_, val) => {
   
   const thingToHash = queryKey instanceof Map || queryKey instanceof Set ? Object.fromEntries([...queryKey.entries()]) : val

    isPlainObject(thingToHash)
      ? Object.keys(thingToHash)
          .sort()
          .reduce((result, key) => {
            result[key] = thingToHash[key]
            return result
          }, {} as any)
      : thingToHash,
    }
  )

[Zentrik]

I think you meant

export function hashKey(queryKey: QueryKey | MutationKey): string {
  return JSON.stringify(queryKey, (_, val) => {
    const thingToHash =
      val instanceof Map || val instanceof Set
        ? Object.fromEntries([...val.entries()])
        : val;

    return isPlainObject(thingToHash)
      ? Object.keys(thingToHash)
          .sort()
          .reduce((result, key) => {
            result[key] = thingToHash[key];
            return result;
          }, {} as any)
      : thingToHash;
  });
}

[Zentrik]

created a pr #9199