Skip to content

test suite has extremely inefficient tests (currently disabled) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aspiers opened this issue Apr 8, 2023 · 3 comments
Open

test suite has extremely inefficient tests (currently disabled) #75

aspiers opened this issue Apr 8, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@aspiers
Copy link
Member

aspiers commented Apr 8, 2023

Currently CI is broken in main and hence for all PRs.

@GigaHierz Any chance you'd have time to look at this?
@aspiers aspiers added bug Something isn't working help wanted Extra attention is needed labels Apr 8, 2023
@aspiers
Copy link
Member Author

aspiers commented Apr 13, 2023

We looked at this together and found that getDynamicRedeemAmount() seems to be very inefficient - spamming the RPC endpoint in parallel with a getBalances() for every TCO2 in the pool! This causes the three BCT tests to be extremely slow, hitting mocha timeout and other weird behaviour.

Should be possible to fix this with https://github.com/0xmichalis/ethers-multicall

@aspiers
Copy link
Member Author

aspiers commented Apr 21, 2023

For now we just disabled the slow tests. Leaving this open for addressing the performance issue.

@aspiers aspiers changed the title test suite is broken test suite has extremely inefficient tests (currently disabled) Apr 21, 2023
@0xmichalis
Copy link
Member

I guess the performance issues come from the fact that the tests run in forking mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aspiers @0xmichalis @GigaHierz