Skip to content

import SignClient from "@walletconnect/sign-client" breaks when cookie are fully disabled #5803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericleponner opened this issue Mar 24, 2025 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@ericleponner
Copy link

Describe the bug

Browser rejects import of SignClient class when it is configured to reject all cookies.
Browser console reports an insecure operation.

To Reproduce

1) Checkout hieror-mirror-node-explorer
   1.1) git clone https://github.com/hiero-ledger/hiero-mirror-node-explorer.git
   1.2) cd hiero-mirror-node-explorer
   1.3) git reset --hard b7b0fa26           # later versions have been applied a workaround
2) npm install
3) npm run dev                              # vite should be bound to https://localhost:5173
4) Starts FireFox and disable all cookies
   4.1) FireFox > Preferences > Privacy & Security
   4.2) Choose 'Custom' option
   4.3) In 'Custom' option panel, set Cookies = 'All cookies (will cause websites to break)'
5) Open https://localhost:5173 with FireFox and accept self-signed certificate 
    => a blank page is displayed
    => FireFox console shows the message below:

SES_UNCAUGHT_EXCEPTION: DOMException: The operation is insecure.
    <anonymous> https://localhost:5174/node_modules/.vite/deps/@walletconnect_sign-client.js?v=d879c7e4:1339

This is reproducible with FireFox 136.0.2 and Safari 18.4.

Expected behavior

At least, import SignClient from @walletconnect/sign-client should not break.

Ideally SignClient API should be able to work with cookies fully disabled.
If not possible, then SignClient API doc should state that cookies are required.

Desktop (please complete the following information):

  • OS: macOS sonoma 14.7.4
  • Browser: FireFox 136.0.2 and Safari 18.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants