Add more test coverage

Author: andrecloutier

.gitignore

@@ -5,6 +5,7 @@ repository
 .vagrant
 keyrings
 /tmp
+.idea
 
 dist/
 

internal/config/config.go

@@ -10,7 +10,6 @@ import (
 	"strings"
 
 	"github.com/mitchellh/go-homedir"
-
 	"github.com/sethvargo/go-envconfig"
 	"gopkg.in/ini.v1"
 )

internal/resolve/resolve.go

@@ -38,7 +38,7 @@ func AllVersions(conf config.Config, plugins []plugins.Plugin, directory string)
 		}
 	}
 
-	// Iterate from the nearest to furthest directory, ending with the user's home.
+	// Iterate from the current towards the root directory, ending with the user's home.
 	for iterDir := range iterDirectories(conf, directory) {
 		// Second: Resolve using the tool versions file
 		filepath := path.Join(iterDir, conf.DefaultToolVersionsFilename)

internal/resolve/resolve_test.go

@@ -141,6 +141,25 @@ func TestAllVersions(t *testing.T) {
 		assert.Equal(t, toolVersion[0].Name, unknownPluginName)
 		assert.Equal(t, toolVersion[0].Versions, []string{"1.2.3"})
 	})
+
+	t.Run("returns results in order from .tool-versions file", func(t *testing.T) {
+		testPluginTwoName := "dummy_plugin_two"
+		_, err := repotest.InstallPlugin("dummy_plugin", conf.DataDir, testPluginTwoName)
+		assert.Nil(t, err)
+		allPlugins := []plugins.Plugin{plugins.New(conf, testPluginName), plugins.New(conf, testPluginTwoName)}
+
+		// write a version file
+		unknownPluginName := "dummy_unknown_plugin"
+		data := []byte(fmt.Sprintf("%s 1.2.3\n%s 1.2.3\n%s 1.2.3", testPluginTwoName, testPluginName, unknownPluginName))
+		err = os.WriteFile(filepath.Join(currentDir, ".tool-versions"), data, 0o666)
+		assert.Nil(t, err)
+
+		toolVersion, err := AllVersions(conf, allPlugins, currentDir)
+		assert.Nil(t, err)
+		assert.Equal(t, toolVersion[0].Name, testPluginTwoName)
+		assert.Equal(t, toolVersion[1].Name, testPluginName)
+		assert.Equal(t, toolVersion[2].Name, unknownPluginName)
+	})
 }
 
 func TestFindVersionsInDir(t *testing.T) {