Skip to content

fix: completion bash #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Conversation

jn-jairo
Copy link
Contributor

@jn-jairo jn-jairo commented Feb 4, 2025

Summary

Rewrite of the completion bash removing the hyphenated commands and adapting the other changes in command line.

Fixes: #1867

@jn-jairo jn-jairo requested a review from a team as a code owner February 4, 2025 21:25
@Stratus3D
Copy link
Member

Hi @jn-jairo thanks for the PR! It looks like these changes failed the Bash lint check. Can you adjust the formatting?

@jn-jairo
Copy link
Contributor Author

jn-jairo commented Feb 5, 2025

Updated with the correct code style.

@Stratus3D Stratus3D merged commit fdb1bc7 into asdf-vm:master Feb 6, 2025
7 checks passed
@Stratus3D
Copy link
Member

Thanks @jn-jairo ! This fix should ship sometime this week.

@Stratus3D Stratus3D mentioned this pull request Feb 6, 2025
@Stratus3D
Copy link
Member

Want to take a stab at doing this for zsh @jn-jairo ?

@jn-jairo
Copy link
Contributor Author

jn-jairo commented Feb 6, 2025

Want to take a stab at doing this for zsh @jn-jairo ?

Sorry, I don't use zsh.

I looked at the code but it's not as simple as the bash one.

I'm not a specialist at completion script, I managed to edit the bash one because that one is pretty simple.

@Stratus3D
Copy link
Member

Thanks @jn-jairo , I'm no expert at completion scripts in any shell 😆 . Going to try to fix the zsh and fish ones tonight.

@jn-jairo jn-jairo deleted the fix-completion-bash branch February 8, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: [0.16.0] Completion bash using old hyphenated commands
2 participants