You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have identified a regression in asdf versions 0.16.6 and 0.16.7 that affects the Zsh completion functionality. Specifically, when using the set command to configure the current Java JDK version, the completion system incorrectly suggests all installable JDK versions instead of only listing the currently installed JDK versions.
This issue was not present in asdf version 0.16.5, where the command completion correctly displayed only the JDK versions installed on the system.
Steps to Reproduce
Install asdf v0.16.6 or v0.16.7.
Use Zsh as your shell.
Run the following command and attempt auto-completion:
asdf set java
Observe that the completion suggests all available JDKs (installable), rather than only the installed ones.
Downgrade to asdf v0.16.5.
Run the same command again.
Observe that the correct behavior is restored, showing only installed JDK versions.
Expected Behaviour
When using the set command in Zsh completion, only the JDK versions installed on the system should be suggested.
Actual Behaviour
When using the set command in Zsh completion, in versions 0.16.6 and 0.16.7, the completion instead lists all installable JDK versions.
@michelemadonnaasdf set can be used to set any version of a tool. Setting a tool to a valid version that isn't installed is a pretty common pattern. Define all the tool versions you want to use for a project, then run asdf install to get everything installed.
I guess the question is here, do we want to suggest uninstalled versions differently than installed versions? It's understandable that some users may want to choose from a list of already installed versions.
I guess the question is here, do we want to suggest uninstalled versions differently than installed versions? It's understandable that some users may want to choose from a list of already installed versions.
I guess the question is here, do we want to suggest uninstalled versions differently than installed versions? It's understandable that some users may want to choose from a list of already installed versions.
The previous implementation was designed as an efficient way to switch between already installed versions of a tool on the system. This was particularly useful for users who wanted a quick way to work with available versions without dealing with uninstalled ones.
Additionally, the asdf set command does not currently install any uninstalled versions of the selected tool. This reinforces its role as a simple switch for existing installations rather than a mechanism for defining and fetching versions not yet present.
While suggesting uninstalled versions might be beneficial in some cases, it's important to consider that many users expect to select only from what's already installed.
Describe the Bug
I have identified a regression in asdf versions 0.16.6 and 0.16.7 that affects the Zsh completion functionality. Specifically, when using the set command to configure the current Java JDK version, the completion system incorrectly suggests all installable JDK versions instead of only listing the currently installed JDK versions.
This issue was not present in asdf version 0.16.5, where the command completion correctly displayed only the JDK versions installed on the system.
Steps to Reproduce
Expected Behaviour
When using the set command in Zsh completion, only the JDK versions installed on the system should be suggested.
Actual Behaviour
When using the set command in Zsh completion, in versions 0.16.6 and 0.16.7, the completion instead lists all installable JDK versions.
Environment
asdf plugins affected (if relevant)
java
The text was updated successfully, but these errors were encountered: