Skip to content

CI should check that base beets specifies it dependencies completely #5713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wisp3rwind opened this issue Apr 8, 2025 · 1 comment
Open
Labels
testing Relates to the testing/CI infrastructure

Comments

@wisp3rwind
Copy link
Member

See the discussion in #5695: We might want to run CI without any extras activated to verify that also in that case, all dependencies are pulled in.

@wisp3rwind wisp3rwind added the testing Relates to the testing/CI infrastructure label Apr 8, 2025
@semohr
Copy link
Contributor

semohr commented Apr 8, 2025

Additionally, we could move the typing_extensions into the main dependencies. I don't see why this would be a bad choice either.

There might be some future python typing features we want to use in the codebase without moving the minimal python requirement. E.g. using ReadOnly would require python 3.13 without typing extensions. At the moment we could not use this feature at all, as typing_extensions would be required for python > 3.10 which we are not installing as it is an extra.

Also typing_extensions is most likely the only dependency that is pulled in via some extras, which shouldn't be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to the testing/CI infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants