Skip to content

plugins: use the regular plugin loading infrastructure in tests #5741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wisp3rwind opened this issue Apr 18, 2025 · 0 comments
Open

plugins: use the regular plugin loading infrastructure in tests #5741

wisp3rwind opened this issue Apr 18, 2025 · 0 comments
Labels
testing Relates to the testing/CI infrastructure

Comments

@wisp3rwind
Copy link
Member

wisp3rwind commented Apr 18, 2025

cf. #5701 (comment)

It appears that none of our tests exercise plugins.load_plugins. We should try to make the tests use that instead of a mock. If that's not possible, we should probably try to run some end-to-end (CLI + real music files) tests in CI.

EDIT: Or maybe we do use load_plugins, but there appears to be some difference, see the discussion in the linked comment thread.

@wisp3rwind wisp3rwind added the testing Relates to the testing/CI infrastructure label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to the testing/CI infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant