Skip to content

[FEATURE] Add the ability to listen on UNIX sockets #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackyzy823 opened this issue Sep 20, 2021 · 3 comments
Closed

[FEATURE] Add the ability to listen on UNIX sockets #436

jackyzy823 opened this issue Sep 20, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@jackyzy823
Copy link

jackyzy823 commented Sep 20, 2021

Describe the feature you'd like to see added
it would be very helpful that whoogle supports listening on UNIX sockets.

Additional context

waitress supports unix_socket. link

However it may conflict with listen link

Thanks.

@jackyzy823 jackyzy823 added the enhancement New feature or request label Sep 20, 2021
@jackyzy823
Copy link
Author

Besides.

environment HTTPS_ONLY do not work since it is shadowed by args.https_only ,

os.environ['HTTPS_ONLY'] = '1' if args.https_only else ''

@PrivacyDevel
Copy link
Contributor

The permissions of the Unix socket seem to be too restrictive. Only the owner of the socket is able to connect to it, which prevents a reverse proxy from being able to connect to it if the reverse proxy is run as a different user. Which should pretty much always be the case.

@master-hax
Copy link
Contributor

@PrivacyDevel i have put up a fix for the issue in #1103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants