Skip to content

[BUG] locally hosted services with IP addresses are still prepended with m. and mobile. #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
cazwacki opened this issue Jan 2, 2023 · 1 comment · Fixed by #922
Closed
2 of 8 tasks
Labels
bug Something isn't working

Comments

@cazwacki
Copy link
Contributor

cazwacki commented Jan 2, 2023

When setting the social media redirect to a locally hosted service, ex. http://192.168.0.209:3401, if mobile links appear, the link will point to http://mobile.192.168.0.209:3401 or http://m.192.168.0.209:3401. I think this requires the same solution as #913.

To Reproduce
Steps to reproduce the behavior:

  1. Set one of the social media redirect environment variables to a locally hosted service
  2. Enable social media redirects in the service
  3. Search for something with mobile links (I searched "twitter dead by daylight")
  4. Hover over mobile links and see the URL

Deployment Method

  • Heroku (one-click deploy)
  • Docker
  • run executable
  • pip/pipx
  • Other: [describe setup]

Version of Whoogle Search

  • Latest build from [source] (i.e. GitHub, Docker Hub, pip, etc)
  • Version [version number]
  • Not sure

Desktop (please complete the following information):

  • OS: unRAID
  • Browser: Firefox
  • Version: Latest build from source
@cazwacki cazwacki added the bug Something isn't working label Jan 2, 2023
@cazwacki
Copy link
Contributor Author

cazwacki commented Jan 2, 2023

Created PR #922 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant