CCT-1081 FEAT Remove unused classes and functions - including Conduits/Slots/Hooks for pre/post_subscribe

Remove "pre_subscribe" and "post_subscribe" plugin slots by removing classes SubscriptionConduit and PostSubscriptionConduit.

CARD: CCT-1081

Author: grunwmar

example-plugins/dbus_event.py

@@ -83,9 +83,3 @@ def pre_product_id_install_hook(self, conduit):
 
     def post_product_id_install_hook(self, conduit):
         self._dbus_event("post_product_id_install", conduit)
-
-    def pre_subscribe_hook(self, conduit):
-        self._dbus_event("pre_subscribe", conduit)
-
-    def post_subscribe_hook(self, conduit):
-        self._dbus_event("post_subscribe", conduit)

example-plugins/subscribe.py

@@ -367,40 +367,6 @@ def __init__(
         self.ent_source: EntitlementSource = ent_source
 
 
-class SubscriptionConduit(BaseConduit):
-    """Conduit for subscription info."""
-
-    slots = ["pre_subscribe"]
-
-    def __init__(self, clazz: Type[SubManPlugin], consumer_uuid: str, pool_id: str, quantity: int):
-        """init for SubscriptionConduit
-
-        Args:
-            consumer_uuid: the UUID of the consumer being subscribed
-            pool_id: the id of the pool the subscription will come from (None if 'auto' is False)
-            quantity: the quantity to consume from the pool (None if 'auto' is False).
-        """
-        super(SubscriptionConduit, self).__init__(clazz)
-        self.consumer_uuid: str = consumer_uuid
-        self.pool_id: str = pool_id
-        self.quantity: int = quantity
-
-
-class PostSubscriptionConduit(BaseConduit):
-    slots = ["post_subscribe"]
-
-    def __init__(self, clazz: Type[SubManPlugin], consumer_uuid: str, entitlement_data: Dict):
-        """init for PostSubscriptionConduit
-
-        Args:
-            consumer_uuid: the UUID of the consumer subscribed
-            entitlement_data: the data returned by the server
-        """
-        super(PostSubscriptionConduit, self).__init__(clazz)
-        self.consumer_uuid: str = consumer_uuid
-        self.entitlement_data: Dict = entitlement_data
-
-
 class PluginConfig:
     """Represents configuation for each rhsm plugin.
 
@@ -886,9 +852,7 @@ def _get_conduits(self) -> List[type(BaseConduit)]:
             RegistrationConduit,
             PostRegistrationConduit,
             FactsConduit,
-            SubscriptionConduit,
             UpdateContentConduit,
-            PostSubscriptionConduit,
         ]
 
     def _get_modules(self):

src/subscription_manager/plugins.py

@@ -308,7 +308,7 @@ def test_a_msg(self):
         self.assertEqual("%s\n" % msg, cap.err)
 
     def test_msg_unicode(self):
-        msg: str = "\u2620 \u2603 \u203D"
+        msg: str = "\u2620 \u2603 \u203d"
         with Capture() as cap:
             try:
                 system_exit(1, msg)

test/test_managercli.py

@@ -1056,25 +1056,6 @@ def test_post_registration_conduit(self):
         self.assertEqual({}, conduit.facts)
 
 
-class TestSubscriptionConduit(unittest.TestCase):
-    def test_subscription_conduit(self):
-        conduit = plugins.SubscriptionConduit(
-            StubPluginClass, consumer_uuid="123456789", pool_id="4444", quantity=4
-        )
-        self.assertEqual("123456789", conduit.consumer_uuid)
-        self.assertEqual(4, conduit.quantity)
-        self.assertEqual("4444", conduit.pool_id)
-
-
-class TestPostSubscriptionConduit(unittest.TestCase):
-    def test_post_subscription_conduit(self):
-        conduit = plugins.PostSubscriptionConduit(
-            StubPluginClass, consumer_uuid="123456789", entitlement_data={}
-        )
-        self.assertEqual("123456789", conduit.consumer_uuid)
-        self.assertEqual({}, conduit.entitlement_data)
-
-
 class BasePluginException(unittest.TestCase):
     """At least create and raise all the exceptions."""