Skip to content

Multipass GUI does not honour question close setting when quitting from the tray #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ricab opened this issue Feb 5, 2025 · 1 comment · May be fixed by #4068
Open

Multipass GUI does not honour question close setting when quitting from the tray #3919

ricab opened this issue Feb 5, 2025 · 1 comment · May be fixed by #4068
Labels
bug jira Create a Jira ticket for this issue medium Medium priority. Combine with "low" or "high" to signal intermediate priority.

Comments

@ricab
Copy link
Collaborator

ricab commented Feb 5, 2025 •
edited
Loading

Describe the bug

This setting:

Image

Doesn't appear to honoured when I click quit on the tray. Running instances carry on even if I have "Stop running instances" and the question is not shown if I have "Ask...".

To Reproduce

  1. Open the GUI
  2. Start an instance
  3. Configure the setting above
  4. Click the tray icon and select "Quit"

Expected behavior
The setting would be honoured, by stopping instances or focusing the GUI and showing a question, as appropriate.
@ricab ricab added bug needs triage Issue needs to be triaged medium Medium priority. Combine with "low" or "high" to signal intermediate priority. and removed needs triage Issue needs to be triaged labels Feb 5, 2025
@andrei-toterman andrei-toterman added the jira Create a Jira ticket for this issue label Feb 5, 2025
@Artem-OSSRevival
Copy link

Hi there. I am Artem from OSS Revival. We specialize in revitalizing and maintaining open-source projects for long-term stability. I'm already working on a solution to this issue.

Artem-OSSRevival added a commit to Project-OSS-Revival/multipass that referenced this issue Apr 28, 2025
@Artem-OSSRevival
Honour the close setting when quitting from the tray canonical#3919
6b3bcc8 
Previously, the tray menu action "Quit" caused a function to immediately destroy the window. Now the usual process of closing window is taking place.

Signed-off-by: Artem <[email protected]>
Artem-OSSRevival added a commit to Project-OSS-Revival/multipass that referenced this issue Apr 28, 2025
@Artem-OSSRevival
Honour the close setting when quitting from the tray canonical#3919
eaae4ba 
Previously, the tray menu action "Quit" caused a function to immediately destroy the window. Now the usual process of closing window is taking place.

Signed-off-by: Artem <[email protected]>
@Artem-OSSRevival Artem-OSSRevival linked a pull request May 1, 2025 that will close this issue
Open
Artem-OSSRevival added a commit to Project-OSS-Revival/multipass that referenced this issue May 2, 2025
@Artem-OSSRevival
Honour the close setting when quitting from the tray canonical#3919
b76e4ca 
Previously, the tray menu action "Quit" caused a function to immediately destroy the window. Now the usual process of closing window is taking place.

Signed-off-by: Artem <[email protected]>
Artem-OSSRevival added a commit to Project-OSS-Revival/multipass that referenced this issue May 6, 2025
@Artem-OSSRevival
Honour the close setting when quitting from the tray canonical#3919
58a2c07 
Previously, the tray menu action "Quit" caused a function to immediately destroy the window. Now the usual process of closing window is taking place.

Signed-off-by: Artem <[email protected]>
Artem-OSSRevival added a commit to Project-OSS-Revival/multipass that referenced this issue May 6, 2025
@Artem-OSSRevival
Honour the close setting when quitting from the tray canonical#3919
f5cd212 
Previously, the tray menu action "Quit" caused a function to immediately destroy the window. Now the usual process of closing window is taking place.

Signed-off-by: Artem <[email protected]>
Artem-OSSRevival added a commit to Project-OSS-Revival/multipass that referenced this issue May 6, 2025
@Artem-OSSRevival
Honour the close setting when quitting from the tray canonical#3919
9c77a59 
Previously, the tray menu action "Quit" caused a function to immediately destroy the window. Now the usual process of closing window is taking place.

Signed-off-by: Artem <[email protected]>
Artem-OSSRevival added a commit to Project-OSS-Revival/multipass that referenced this issue May 26, 2025
@Artem-OSSRevival
Honour the close setting when quitting from the tray canonical#3919
de7ebd5 
Previously, the tray menu action "Quit" caused a function to immediately destroy the window. Now the usual process of closing window is taking place.

Signed-off-by: Artem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug jira Create a Jira ticket for this issue medium Medium priority. Combine with "low" or "high" to signal intermediate priority.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Honour the close settings when quitting from the tray Project-OSS-Revival/multipass
3 participants
@ricab @andrei-toterman @Artem-OSSRevival