Skip to content

Visibility Issue with colorscheme #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waivek opened this issue Jul 3, 2023 · 5 comments
Open

Visibility Issue with colorscheme #370

waivek opened this issue Jul 3, 2023 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@waivek
Copy link

waivek commented Jul 3, 2023

mcfly

The menu contrast is difficult to read.
The first match blends in.

@cantino cantino added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jul 7, 2023
@movy
Copy link

movy commented Feb 17, 2025

Along the same lines, is there an option to expand (suggest) a command in place of incompletely typed one?
I.e. as in the screenshot above, instead of a typed portion python the command line would've python test.py as it is the currently selected suggestion in the history menu. This would make transition from ctrl-r to McFly easier and (imho) make McFly even more user friendly.

Thanks for your time!

@cantino
Copy link
Owner

cantino commented Feb 17, 2025

@movy Hitting tab accepts the command onto the command line for editing. Is this what you mean?

@waivek Is this the default color scheme or one you've modified?

@movy
Copy link

movy commented Feb 18, 2025

@cantino , below are outputs from vanilla ctrl+r and McFly for typed pyt sequence:

Image

Image

With ctrl-r the whole suggested history item is already in the command line after three key presses, while in McFly we have to switch our attention to the history menu to make sure the command selected is the one we're after. Usually #1 McFly's suggestion is correct, but my guess is that some (many?) long-time ctrl-r users expect to see the suggestion right in the command line to avoid looking down the history menu.

Having the history menu is SUPER nice, don't get me wrong, I just think these two modes (in-line suggestion as we type + history menu) can co-exists for better UX.

@cantino
Copy link
Owner

cantino commented Feb 18, 2025

Ah, I understand now. So in your example the command line would show "python scripts/build_locally.py" with pyt visible / underlined and the rest faded out? I think this might be a stylistic thing since I think I'd find that distracting, but we could add it as an optional feature if someone wants to implement it.

@movy
Copy link

movy commented Feb 19, 2025

something like that, yes. Basically, it allows to see the selected command without switching focus to the menu. I have never used Rust, do you think GPT can help here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants