Skip to content

Support emojis #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shinzui opened this issue Dec 13, 2016 · 3 comments
Open

Support emojis #187

shinzui opened this issue Dec 13, 2016 · 3 comments

Comments

@shinzui
Copy link

shinzui commented Dec 13, 2016

Marked currently does not support emojis and they've had the related issue open for three years now. I suggest switching to another library such as markdown-it.

Marked does not appear to be well maintained based on the number of outstanding issues and pull requests so switching has other benefits.

@claudioc
Copy link
Owner

claudioc commented Jan 8, 2017

I will take a look into this, it's a good point.

I believe I'd need to support both of them for a while to be sure I am not breaking anything (I cannot obviously test that markdown-it would work without any issue with ALL the existing Jingo installations).

Thanks!

@FranklinYu
Copy link

FranklinYu commented Aug 1, 2018

Switching to markdown-it will break something because many fixes are "breaking fix". I think it is safer to do the switch in next major version of Jingo.

Also: https://softwareengineering.stackexchange.com/questions/368030/is-a-breaking-change-bug-fix-a-semver-patch-or-a-major

@claudioc
Copy link
Owner

claudioc commented Aug 4, 2018

@FranklinYu that's what I am doing indeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants