-
-
Notifications
You must be signed in to change notification settings - Fork 649
[ci] Drop Emacs 26, test Emacs 30 #3782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
44bdb91
to
cee79f1
Compare
cider-selector.el
Outdated
(display-buffer (current-buffer) t)) | ||
(cider-selector) | ||
(current-buffer)) | ||
(def-cider-selector-method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better to just specify the indentation in the definition of the macro with:
(declare (indent 1))
I think this should solve the indentation issues here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter story looks harder than I thought. I'll probably revert to 28, too much work getting rid of all byte-compilation warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's prudent. I guess I'll need to address those problems myself down the road.
That's fine by me, although you should probably update the Emacs dep in The indentation changes to |
e42e675
to
e82cd47
Compare
I reverted the linter back to 28, together with the indentation changes. There is a 27 test failing, it also fails on master, so it could be something seasonal. Let's wait and see if it recovers later. |
0bab8aa
to
4c349e5
Compare
4c349e5
to
c9548dc
Compare
f9957f5
to
ace4841
Compare
@bbatsov I've commented Emacs 27 testing for now. |
I think that's fine. I'm now wondering if the problem is not caused by something in Eldev's settings, but overall we can proceed as is for now. |
We have 1 person using Emacs 26 according to State of CIDER 2025 results. Stable debian (Bookworm) ships Emacs 28. Bullseye had 27.