Skip to content

[ci] Drop Emacs 26, test Emacs 30 #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025
Merged

[ci] Drop Emacs 26, test Emacs 30 #3782

merged 3 commits into from
Mar 13, 2025

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented Mar 4, 2025

We have 1 person using Emacs 26 according to State of CIDER 2025 results. Stable debian (Bookworm) ships Emacs 28. Bullseye had 27.

  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

@alexander-yakushev alexander-yakushev force-pushed the ci-drop-26 branch 9 times, most recently from 44bdb91 to cee79f1 Compare March 4, 2025 13:50
(display-buffer (current-buffer) t))
(cider-selector)
(current-buffer))
(def-cider-selector-method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to just specify the indentation in the definition of the macro with:

(declare (indent 1))

I think this should solve the indentation issues here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter story looks harder than I thought. I'll probably revert to 28, too much work getting rid of all byte-compilation warnings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's prudent. I guess I'll need to address those problems myself down the road.

@bbatsov
Copy link
Member

bbatsov commented Mar 4, 2025

That's fine by me, although you should probably update the Emacs dep in cider.el as well. Or we can just keep, until we actually need something from Emacs 27. (I don't recall it being an interesting release) Generally, nothing particularly useful for us happened until Emacs 29.

The indentation changes to cl-flet look somewhat weird to me, but I also saw them in another proposal, so I guess we'll have to stomach them. I'd like to avoid the awkward indentation in the selector methods, though. (at least to me it looks quite confusing)

@alexander-yakushev alexander-yakushev force-pushed the ci-drop-26 branch 3 times, most recently from e42e675 to e82cd47 Compare March 4, 2025 14:03
@alexander-yakushev
Copy link
Member Author

alexander-yakushev commented Mar 4, 2025

I reverted the linter back to 28, together with the indentation changes.

There is a 27 test failing, it also fails on master, so it could be something seasonal. Let's wait and see if it recovers later.

@alexander-yakushev alexander-yakushev force-pushed the ci-drop-26 branch 2 times, most recently from 0bab8aa to 4c349e5 Compare March 4, 2025 14:09
@alexander-yakushev
Copy link
Member Author

@bbatsov I've commented Emacs 27 testing for now.

@bbatsov
Copy link
Member

bbatsov commented Mar 13, 2025

I think that's fine. I'm now wondering if the problem is not caused by something in Eldev's settings, but overall we can proceed as is for now.

@alexander-yakushev alexander-yakushev merged commit ee5ee37 into master Mar 13, 2025
18 checks passed
@alexander-yakushev alexander-yakushev deleted the ci-drop-26 branch March 13, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants