Skip to content

Vendor / rewrite support for protected assets with Azure Storage to not use the Azure SDK #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
travier opened this issue Mar 27, 2025 · 0 comments

Comments

@travier
Copy link
Member

travier commented Mar 27, 2025

Bug

The size of the Ignition binary significantly increased with the 2.21.1 release, likely due to addition of the Azure SDK as vendored code: #1923

For Flatcar:

$ du --si ./bin/amd64/ignition-v2.20.0
38M	./bin/amd64/ignition-v2.20.0
$ du --si ./bin/amd64/ignition-v2.21.0
63M	./bin/amd64/ignition-v2.21.0

For Fedora CoreOS:

We could look at reducing the amount of vendored code, copying only the relevant part for support of this feature or re-implementing only what's needed for it.

Operating System Version

Flatcar & FCOS

Ignition Version

Ignition 2.21.0

Environment

What hardware/cloud provider/hypervisor is being used to run Ignition? Azure but this issue is for all platforms.

Expected Behavior

Ignition binary does not grow too much in size.

Actual Behavior

Significant increase in size.

Reproduction Steps

N/A

Other Information

See: #2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant