-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Vaildation error is not shown on collapsed objects #5630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, can I fix this one? |
Thanks @evelew, a possible place to start is here https://github.com/netlify/netlify-cms/blob/6d801ae092a6763bd751cb82bd238c7c12b31884/packages/netlify-cms-widget-object/src/ObjectControl.js#L66 Also see our contribution guide https://github.com/netlify/netlify-cms/blob/master/CONTRIBUTING.md |
@erezrokah ok, thank you! |
Hi! If this is still available, id like to try to fix it :) |
Hi! i am currently unable to work on this, so id prefer to have it assigned to someone else. Ill come back as soon as i have capacity |
Describe the bug
If a field inside a collapsed object fires a validation error, the entry will not be saved. This is the correct behavior, but the problem is, that there is no indication of where the error occurs.
To Reproduce
Steps to reproduce the behavior. For example:
collapsed: true
Expected behavior
If a field is collapsed and it includes objects with validation errors, it should also be treated as a field with an error. It should get a red border and an explanation text in red color.
Screenshots

Collapsed - there is no indication that a required filed is empty in services object
Uncollapsed

Applicable Versions:
CMS configuration
Example configuration for a collapsed object with a required string field. This happens on any global configuration I believe.
The text was updated successfully, but these errors were encountered: