Question about your code for Node.js built-in modules loading

[nicolo-ribaudo]

Hey,

I was reading how Deno implements require() of built-in Node.js modules, and I noticed this file: https://github.com/denoland/deno/blob/main/ext/node/polyfills/01_require.js

The punycode module is deprecated, so it's defined as a getter with the deprecation warning:

deno/ext/node/polyfills/01_require.js

Lines 243 to 251 in 7d326c2

	get punycode() {
	process.emitWarning(
	"The `punycode` module is deprecated. Please use a userland " +
	"alternative instead.",
	"DeprecationWarning",
	"DEP0040",
	);
	return punycode;
	},

However, that getter is triggered immediately by

deno/ext/node/polyfills/01_require.js

Line 277 in 7d326c2

for (const [name, moduleExports] of ObjectEntries(nodeModules)) {

, which immediately iterates through the object's entries triggering all the getters.

I'm asking this question because I don't actually see the warning unexpectedly, even if by reading the code it seems like the warning would be printed even if punycode is not required. What am I missing?

[bartlomieju]

Good catch, I bet this warning is emitted during V8 snapshot creation (ie. during the build process) and that's why it's never surfaced.