"quote_type" didn't added to editorconfig file.

[pixieaka]

Please fill-in this template.

• I have a question that is specific to this extension; thus, inappropriate for the main EditorConfig issue tracker.
• I tried running code --disable-extensions and the issue did NOT present itself.

Delete the following condition if it doesn't apply to your case:

If the extension is not picking up the expected configuration for a file:

• I tried npm install editorconfig -g and ran editorconfig [file-in-question] and the configuration was what I expected. If not, please file on the editorconfig-core-js issue tracker.

Issue

	Visual Studio Code	editorconfig-vscode
Version	1.55.0	0.16.4

Root .editorconfig File

root = true

[*]
indent_style = space
indent_size = 4
end_of_line = crlf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

Are there any other relevant .editorconfig files in your project? No

Visual Studio Code Setting	Default	User	Workspace
javascript.preferences.quoteStyle	auto		single
typescript.preferences.quoteStyle	auto		single
prettier.singleQuote	false		true
prettier.jsxSingleQuote	"false"		"true"

File opened

./test.js

Expected behavior

indent_style = space
indent_size = 4
end_of_line = crlf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
quote_type = single <<<<<<<<<<<<<<<<<<<<<<<<<<<<< This should be added

Actual behavior

indent_style = space
indent_size = 4
end_of_line = crlf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

Additional comments or steps to reproduce

.

[SunsetTechuila]

The quote_type property is not included in the specification. I believe that official EditorConfig plugins shouldn't interact in any way with such properties.

There is no general quote style option in VSCode. Therefore, if the requested functionality is implemented, the extension should account for different languages. For example, if javascript.preferences.quoteStyle is set to "single" editorconfig should be changed to:

# there should be a key-value collection of settings groups and related file extension
# like { "javascript.preferences": ["js", "mjs"] }
[*.{js,mjs}]
quote_type = single

All options are provided by extensions (either built-in or external) and must be manually checked. All of this will become a mess in the blink of an eye. Respecting formatter-specific preferences isn't realistically possible, as there are many formatters, each supporting different languages and having different settings that affect how and to which files options are applied.

@xuhdev request your opinion

[SunsetTechuila]

@xuhdev you responded to two mentions yesterday, so tagging you again

[xuhdev]

@SunsetTechuila Sorry I missed your message earlier.

The quote_type property is not included in the specification. I believe that official EditorConfig plugins shouldn't interact in any way with such properties.

Editor plugins can support custom properties, and I don't believe we have a strict definition of "official" plugins here -- so far most editor plugin developers enjoy a high degree of freedom. However, we don't have a uniform opinion on the naming of such custom properties yet, see editorconfig/editorconfig#332 . However, likely we should add some unique prefix at the very least, such as vscode_quote_type.

There is no general quote style option in VSCode. Therefore, if the requested functionality is implemented, the extension should account for different languages. For example, if javascript.preferences.quoteStyle is set to "single" editorconfig should be changed to:

# there should be a key-value collection of settings groups and related file extension
# like { "javascript.preferences": ["js", "mjs"] }
[*.{js,mjs}]
quote_type = single

All options are provided by extensions (either built-in or external) and must be manually checked. All of this will become a mess in the blink of an eye. Respecting formatter-specific preferences isn't realistically possible, as there are many formatters, each supporting different languages and having different settings that affect how and to which files options are applied.

I don't understand VSCode that much and will always leave VSCode specific decisions to you 😉

[thw0rted]

The quote_type property is not included in the specification. I believe that official EditorConfig plugins shouldn't interact in any way with such properties.

Not included in the spec but see editorconfig/editorconfig#410 which points to https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#ideas-for-domain-specific-properties where quote_type is the first nonstandard property on the list. It might also be worth considering what other tooling looks at this value -- several commenters have brought up support in prettier, for example.