Should type coercion convert number/boolean literals?

[elecdeer]

I noticed that Conform's automatic type coercion and coerceFormValue do not convert z.literal(0) or z.literal(true).
While we can force the conversion by writing z.number().pipe(z.literal(1)) and z.boolean().pipe(z.literal(true)) respectively, this feels awkward as a schema definition.

Should Conform support these cases?

A practical use case would be a checkbox to confirm agreement to terms and conditions.

test("z.literal", () => {
  const schema = z.object({
    a: z.literal("a"),
    b: z.literal(1),
    b2: z.number().pipe(z.literal(1)),
    c: z.literal(true),
    c2: z.boolean().pipe(z.literal(true)),
  });

  expect(
    getResult(
      coerceFormValue(schema).safeParse({
        a: "a",
        b: "1",
        b2: "1",
        c: "on",
        c2: "on",
      }),
    ),
  ).toEqual({
    success: true,
    data: {
      a: "a",
      b: 1,
      b2: 1,
      c: true,
      c2: true,
    },
  });

  // actual:
  // Object {
  // 	"error": Object {
  // 		"b": Array [
  // 			"Invalid literal value, expected 1",
  // 		],
  // 		"c": Array [
  // 			"Invalid literal value, expected true",
  // 		],
  // 	},
  // 	"success": false,
  // }
});

Related

• Intended way to use a discriminatedUnion boolean with a Checkbox #867

[chimame]

hi @elecdeer

Thank you for opening the discussion.
I understand that you want to support literals other than strings. If it's possible to implement it, I think it's fine.

[elecdeer]

Thanks for the response.
I've implemented it with zod for now, so I created a PR: #930