Skip to content

Add comments why unprefixedHexToBytes or bytesToUnprefixedHex is used #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jochem-brouwer opened this issue Apr 19, 2025 · 0 comments
Open
Assignees

Comments

@jochem-brouwer
Copy link
Member

In some places in the monorepo we use unprefixedHexToBytes or bytesToUnprefixedHex. Those are methods from util which are marked as deprecated. We still use those in certain places with in most/all cases an optimization argument. We should review where these deprecated are used, and if there are still arguments why we should keep using those, we should explicitly comment why this is used such that we dont accidentally change this.

Will assign myself here, I think most of them were left as using the deprecated variant once we changed using those utilities from ethereum-cryptography to using our own exported variants from @ethereumjs/util

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant