-
Notifications
You must be signed in to change notification settings - Fork 24.7k
App Crashes on Android 32bit When emit event from TurboModule #51628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It seems that on arm32 in packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java this method Line 139 in e7901a7
is called with a null eventEmitterCallback which is assigned to mEventEmitterCallback in the following line. |
Hmm, I wonder if caching Could you try replacing
That would show up as a null pointer exception, which is not the error we're seeing. |
@javache I tried removing the cached method id, but that didn't help. Investigating the code seems that the culpitt might be the use of
@javache could you please verify that the fix is valid? |
Do you have any references on why that would be unsafe on 32-bit? Switching to |
@javache From what I found, the variadic functions like Edit: I also done extensive testing on my application with the above patch and everything seems stable now. |
Hey @javache , @cortinico, Do you think it's possible this fix to be reviewed and included in the |
@vladimirivanoviliev do you have a PR for this? |
Hey everyone, @CaptainJeff, @javache, @cortinico, I just opened PR with the above change: |
Uh oh!
There was an error while loading. Please reload this page.
Description
Hello again everyone, @javache @cortinico.
This is continuation of this thread.
After testing the latest RC and nighly builds, crash appeared when emitting events from turbo modules on 32bit Android devices. The crash is always reproducible only on 32bit devices on signed production builds. I have created reproduction demo, which is basically the official demo code for creating turbo module with event:
note: nightly and v0.80-RC3 versions can be seen as PRs
Steps to reproduce
adb -s YOURDEVICE install --abi armeabi-v7a android/app/release/app-release.apk
React Native Version
0.80-rc3, nightly
Affected Platforms
Runtime - Android
Output of
npx @react-native-community/cli info
Stacktrace or Logs
MANDATORY Reproducer
https://github.com/vladimirivanoviliev/rn079eventcrash
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: