Define JSI bridging function for ShadowNode::Shared #51675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75597542 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Differential Revision: D75597542
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Differential Revision: D75597542
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
from
c900d76 to
f65647d
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Differential Revision: D75597542
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Differential Revision: D75597542
|
This pull request was exported from Phabricator. Differential Revision: D75597542 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: facebook#51675 Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
from
f65647d to
8c285ff
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
from
8c285ff to
4870990
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75597542 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
from
4870990 to
fcfbd58
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
|
This pull request was exported from Phabricator. Differential Revision: D75597542 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: facebook#51675 Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
from
fcfbd58 to
41c1039
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
2 times, most recently
from
aa1b9dc to
3d84f81
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75597542 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D75597542 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: facebook#51675 Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
from
3d84f81 to
b3f79e9
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597542
branch
from
b3f79e9 to
6764e21
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 29, 2025
Summary: Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
Summary: Pull Request resolved: facebook#51675 Changelog: [internal] This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing `shadowNodeFromValue` and `valueFromShadowNode` functions: 1. It's more convenient, as we can just use `ShadowNode::Shared` in classes implementing the codegen, and the runtime will do the conversion automatically. 2. It's safer, as it checks for nullability and throws JS exceptions except of having segmentation faults down the line. Reviewed By: javache Differential Revision: D75597542
|
This pull request was exported from Phabricator. Differential Revision: D75597542 |
rubennorte
force-pushed
the
export-D75597542
branch
from
6764e21 to
4b562fc
Compare
|
This pull request has been merged in 9c21489. |
|
This pull request was successfully merged by @rubennorte in 9c21489 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This defines a new bridging method to convert ShadowNode::Shared from and to JS. This has some benefits over the existing
shadowNodeFromValueandvalueFromShadowNodefunctions:ShadowNode::Sharedin classes implementing the codegen, and the runtime will do the conversion automatically.Differential Revision: D75597542