Adding test cases to check if non-annotated parameters get removed in the RemoveUnusedArgs pass

Summary:
Added test cases for the change in D75252795 to ensure that the code works as intended.

I added an interface into `RemovedUnusedArgsTest.java` called `AnnotatedParameterInterface`, which contains one method with an annotated parameter, and another method with no annotated parameters. The annotation is custom, and defined as `CustomAnnotation`.

The test PostVerify tests, named `DontRemoveAnnotatedParameter` and `RemoveNonAnnotatedParameter` will check if the pass does not remove the method that has annotated parameters, and the other one checks if it does remove the one without annotated parameters.

Reviewed By: wsanville

Differential Revision: D75257372

fbshipit-source-id: f67701ffb9b9fbc00f1b66e7a92a5c2d2884a25f

Author: Bill Zhang

test/instr/RemoveUnusedArgsTest.cpp

@@ -1105,4 +1105,36 @@ TEST_F(PostVerify, RemoveAbstractUnusedArg) {
   check_callsite_regs(use_foo, 1, 1);
 }
 
+TEST_F(PostVerify, DontRemoveAnnotatedParameter) {
+  auto annotated_parameter_class = find_class_named(
+      classes, "Lcom/facebook/redex/test/instr/AnnotatedParameterInterface;");
+  ASSERT_NE(nullptr, annotated_parameter_class);
+
+  auto annotated_parameter_method = find_vmethod(
+      *annotated_parameter_class, "annotated_parameter_method_1", "(I)V");
+  ASSERT_NE(nullptr, annotated_parameter_method);
+}
+
+TEST_F(PostVerify, RemoveNonAnnotatedParameterSingleParameterMethod) {
+  auto annotated_parameter_class = find_class_named(
+      classes, "Lcom/facebook/redex/test/instr/AnnotatedParameterInterface;");
+  ASSERT_NE(nullptr, annotated_parameter_class);
+
+  auto annotated_parameter_method = find_vmethod(
+      *annotated_parameter_class, "annotated_parameter_method_2", "(I)V");
+
+  ASSERT_EQ(nullptr, annotated_parameter_method);
+}
+
+TEST_F(PostVerify, DontRemoveNonAnnotatedParameterMultiParameterMethod) {
+  auto annotated_parameter_class = find_class_named(
+      classes, "Lcom/facebook/redex/test/instr/AnnotatedParameterInterface;");
+  ASSERT_NE(nullptr, annotated_parameter_class);
+
+  auto annotated_parameter_method = find_vmethod(
+      *annotated_parameter_class, "annotated_parameter_method_3", "(II)V");
+
+  ASSERT_NE(nullptr, annotated_parameter_method);
+}
+
 } // namespace

test/instr/RemoveUnusedArgsTest.java

@@ -7,6 +7,11 @@
 
 package com.facebook.redex.test.instr;
 
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+import java.lang.annotation.RetentionPolicy;
+
 import javax.security.auth.x500.X500Principal;
 
 class Foo {
@@ -434,3 +439,17 @@ public void reorderable2(Object x, double y, int z) {
   public void reorderable2(Object x, int y, double z) {
   }
 }
+
+@Retention(RetentionPolicy.RUNTIME)
+@Target(ElementType.PARAMETER)
+@interface CustomAnnotation {
+  String value() default "";
+}
+
+interface AnnotatedParameterInterface {
+  public void annotated_parameter_method_1(@CustomAnnotation("annotation 1") int x);
+
+  public void annotated_parameter_method_2(int x);
+
+  public void annotated_parameter_method_3(int x, @CustomAnnotation("annotation 2") int y);
+}