-
Notifications
You must be signed in to change notification settings - Fork 326
[babel-plugin] Better options for processStylexRules #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've implemented this solution, but I have some about a breaking change. Please take a look and let me know your thoughts. More details are available in the PR description. #1072 |
This is not entirely possible. Based on the StyleX design for media queries and pseudo classes, all longhand styles should have higher specificity than shorthand styles. This is also needed for RN support to work correctly. Therefore, we need a plain This means we need some way to bump the specificity, which means a |
I've carefully reviewed the feedback on the #1072 and am currently working on addressing the points. I'll update the PR soon. @nmn, I now fully understand that for StyleX's design and RN support, ensuring longhand styles override shorthand styles requires achieving higher specificity, which in turn necessitates the use of Considering this situation, I'd appreciate hearing the maintainers' thoughts on the future direction of this issue.
I'm keen to help resolve this issue. |
You can do it without adding "none" for now. We don't use any layers stuff internally, but that won't be the case for long so we might not need "none" for long anyway |
In particular, we should be able to support generating CSS files that:
@layer
or a polyfill.@layer
.@layer
.The text was updated successfully, but these errors were encountered: