fix: Remove all DOM events when off with no arg is called

Author: finom

src/_dom/mq/off.js

@@ -17,8 +17,25 @@ export default function off(namesStr, selector, handler) {
 
         for (let j = 0; j < this.length; j++) {
             const node = this[j];
-            const events = data.allEvents[name + node.b$];
 
+            if (!name && namespace) {
+                for (let k = 0, keys = Object.keys(data.allEvents); k < keys.length; k++) {
+                    const events = data.allEvents[keys[k]];
+
+                    for (let l = 0; l < events.length; l++) {
+                        const event = events[i];
+                        if (event.namespace === namespace && event.nodeID === node.b$) {
+                            node.removeEventListener(event.name, event.delegate || event.handler);
+                            events.splice(l, 1);
+                            l -= 1;
+                        }
+                    }
+                }
+
+                continue;
+            }
+
+            const events = data.allEvents[name + node.b$];
             if (events) {
                 for (let k = 0; k < events.length; k++) {
                     const event = events[k];

src/_dom/mq/on.js

@@ -75,7 +75,9 @@ export default function on(namesStr, selector, handler) {
                     delegate,
                     handler,
                     namespace,
-                    selector
+                    selector,
+                    nodeID,
+                    name
                 });
 
                 node.addEventListener(name, delegate || handler, false);

src/off/index.js

@@ -3,6 +3,7 @@ import checkObjectType from '../_helpers/checkobjecttype';
 import defs from '../_core/defs';
 import removeListener from './_removelistener';
 import undelegateListener from './_undelegatelistener';
+import dom from '../_dom';
 
 // removes event listener
 export default function off(object, givenNames, callback, context) {
@@ -30,8 +31,17 @@ export default function off(object, givenNames, callback, context) {
         return object;
     }
 
+
     if (!givenNames && !callback && !context) {
         def.events = {};
+
+        nofn.forOwn(def.props, ({ bindings }, propName) => {
+            nofn.forEach(bindings, ({ node }) => {
+                const eventNamespace = def.id + propName;
+                dom.$(node).off(`.${eventNamespace}`);
+            });
+        });
+
         return object;
     }
 

test/spec/events/events_summary_spec.js

@@ -112,6 +112,7 @@ describe('Events summary (on, once, onDebounce, off, trigger)', () => {
         expect(handler).not.toHaveBeenCalled();
     });
 
+
     it('triggers DOM event using selector', () => {
         bindNode(obj, 'x', '#child');
         on(obj, 'click::x(.grandchild)', handler);
@@ -306,4 +307,14 @@ describe('Events summary (on, once, onDebounce, off, trigger)', () => {
         onDebounce.call(obj, 'someevent', handler, 100);
         trigger(obj, 'someevent');
     });
+
+    it('removes all events when off is called with no args', () => {
+        on(obj, 'click::x', handler);
+        bindNode(obj, 'x', '#child');
+        on(obj, 'foo', handler);
+        off(obj);
+        simulateClick(childNode);
+        trigger(obj, 'foo');
+        expect(handler).not.toHaveBeenCalled();
+    });
 });