Failed API calls should not be failures, not errors #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

SamMorrowDrums opened this issue May 21, 2025 · 0 comments

Assignees

Collaborator

SamMorrowDrums commented May 21, 2025

An example:

github-mcp-server/pkg/github/context_tools.go

Line 34 in 4ccedee

return nil, fmt.Errorf("failed to get user: %w", err)

As discussed here and here in general failures of this kind are not to be returned as errors, but instead returned as failed tool calls.

williammartin self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment