-
Notifications
You must be signed in to change notification settings - Fork 499
Update to Bazel version 8+ #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related upstream issue for tracking: bazelbuild/rules_closure#616 |
FWIW: Bazel 8.0.0 has the |
Thanks @fulldecent , @bcsgh - I got the recommendation for 7.4.1 from @gkdn, one of the rules_closure committers. After spending about two days to move it to 8.0.0 then back to 7.4.1 and get it all working I'm ok with leaving it there for now. 🐢 |
I just tried adding a # C implementation. Lives in c/, tested with bazel.
test-c:
runs-on: ubuntu-latest
env:
OLC_PATH: c
steps:
- uses: actions/checkout@v4
- uses: bazelbuild/setup-bazelisk@v3
- name: test
run: bazel test --test_output=all ${OLC_PATH}:all
- name: check formatting
run: cd ${OLC_PATH} && bash clang_check.sh and got the error:
Looking at the github action https://github.com/bazelbuild/setup-bazelisk it says it's superseded and may stop working someday. I guess today is that day. UPDATE: This looks like it was transitory, a retry was ok. |
This is a placeholder issue.
Once Bazel JS closure rules (https://github.com/bazelbuild/rules_closure) is available as a Bazel module, it should be moved from the
WORSKSPACE
file toMODULE.bazel
, and the Bazel version specified in.bazeliskrc
can be updated to whatever is the current version.Until then, we can't go past Bazel version 7.4.1 (since later versions do not use the
WORKSPACE
file to load dependencies).The text was updated successfully, but these errors were encountered: