Skip to content

Update tests to use integer values for encoding #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drinckes opened this issue Jan 9, 2025 · 2 comments
Open

Update tests to use integer values for encoding #674

drinckes opened this issue Jan 9, 2025 · 2 comments
Assignees

Comments

@drinckes
Copy link
Contributor

drinckes commented Jan 9, 2025

Update the tests for each implementation to use the integer coordinates in the encoding test data and the integer encoding function.

Should also add a test to confirm that the conversion from degrees to integer is within expectations.

@drinckes drinckes self-assigned this Apr 15, 2025
@drinckes
Copy link
Contributor Author

It turns out everything can play nicely with floats in the test data, so this is no longer necessary.

@drinckes drinckes reopened this Apr 15, 2025
@drinckes
Copy link
Contributor Author

As per the comment in #716 (comment), once I add tests that confirm a code's bounding box contains the original coordinates I get failures. It doesn't matter whether I use Round() or Floor() in the conversion from float to integer, because the issue is with the accuracy of the float representation.

So I thought I wasn't going to have to do all this but it looks as though I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant