invalid error names used for missing author and commit for schema publish #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

n1ru4l opened this issue May 23, 2025 · 0 comments · May be fixed by #6820

Contributor

n1ru4l commented May 23, 2025

The name GithubCommitRequiredError and GithubAuthorRequiredError is misleading, as the commit and author is nothing that is related to Github.

console/packages/libraries/cli/src/commands/schema/publish.ts

Lines 241 to 248 in d919e2d

    
           if (!author) { 
        
             throw new GithubAuthorRequiredError(); 
        
           } 
        
           if (!commit) { 
        
             throw new GithubCommitRequiredError(); 
        
           }

The text was updated successfully, but these errors were encountered:

n1ru4l linked a pull request

that will close this issue

fix(cli): use correct error codes and add more context #6820

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment