Skip to content

Include identity in import apply UI output #37044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Include identity in import apply UI output #37044

merged 2 commits into from
May 16, 2025

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented May 14, 2025

This PR fixes the UI output during import. It now prints the identity in the pre and post apply hooks.

UX

Before
CleanShot 2025-05-14 at 11 27 06@2x

After
CleanShot 2025-05-14 at 11 27 44@2x

Target Release

1.12.1

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dbanck dbanck requested a review from a team as a code owner May 14, 2025 09:28
@dbanck dbanck added bug 1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels May 14, 2025
radeksimko
radeksimko reviewed May 14, 2025
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question, with the new "unknown" field in the machine-readable output - is that anything that would possibly need to be reflected here as well? I assume not, but wanted to double check.

@dbanck
Copy link
Member Author

dbanck commented May 14, 2025

One more question, with the new "unknown" field in the machine-readable output - is that anything that would possibly need to be reflected here as well? I assume not, but wanted to double check.

I believe at this stage everything should be known and there is no need to check this field

@dbanck dbanck force-pushed the dbanck/fix-import-ui-identity branch from db869d1 to bbe08a1 Compare May 16, 2025 13:05
@dbanck dbanck requested a review from radeksimko May 16, 2025 13:06
@dbanck dbanck merged commit 8213714 into main May 16, 2025
9 checks passed
@dbanck dbanck deleted the dbanck/fix-import-ui-identity branch May 16, 2025 13:24
@github-actions github-actions bot mentioned this pull request May 16, 2025
Closed
2 tasks
dbanck added a commit that referenced this pull request May 16, 2025
@dbanck
Include identity in import apply UI output (#37044)
0ef0e67 
* Include identity in import apply UI output

* Add logging to hook ui errors
@dbanck dbanck mentioned this pull request May 16, 2025
Merged
3 tasks
dbanck added a commit that referenced this pull request May 16, 2025
@dbanck
Include identity in import apply UI output (#37044) (#37077)
e1c60d1 
* Include identity in import apply UI output

* Add logging to hook ui errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
1.12-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @radeksimko