fix: drop default quota field

wuzihao051119 · wuzihao051119 · commit d9f869593435 · 2025-05-23T20:05:48.000+08:00
diff --git a/mobile/openapi/lib/model/system_config_o_auth_dto.dart b/mobile/openapi/lib/model/system_config_o_auth_dto.dart
diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.json
@@ -13687,7 +13687,6 @@
           "defaultStorageQuota": {
             "format": "int64",
             "minimum": 0,
-            "nullable": true,
             "type": "integer"
           },
           "enabled": {
@@ -13736,7 +13735,6 @@
           "buttonText",
           "clientId",
           "clientSecret",
-          "defaultStorageQuota",
           "enabled",
           "issuerUrl",
           "mobileOverrideEnabled",
diff --git a/open-api/typescript-sdk/src/fetch-client.ts b/open-api/typescript-sdk/src/fetch-client.ts
@@ -1316,7 +1316,7 @@ export type SystemConfigOAuthDto = {
     buttonText: string;
     clientId: string;
     clientSecret: string;
-    defaultStorageQuota?: number | null;
+    defaultStorageQuota?: number;
     enabled: boolean;
     issuerUrl: string;
     mobileOverrideEnabled: boolean;
diff --git a/server/src/config.ts b/server/src/config.ts
@@ -89,7 +89,7 @@ export interface SystemConfig {
     buttonText: string;
     clientId: string;
     clientSecret: string;
-    defaultStorageQuota: number | null;
+    defaultStorageQuota?: number;
     enabled: boolean;
     issuerUrl: string;
     mobileOverrideEnabled: boolean;
@@ -253,7 +253,6 @@ export const defaults = Object.freeze<SystemConfig>({
     buttonText: 'Login with OAuth',
     clientId: '',
     clientSecret: '',
-    defaultStorageQuota: null,
     enabled: false,
     issuerUrl: '',
     mobileOverrideEnabled: false,
diff --git a/server/src/dtos/system-config.dto.ts b/server/src/dtos/system-config.dto.ts
@@ -360,9 +360,9 @@ class SystemConfigOAuthDto {
 
   @IsNumber()
   @Min(0)
-  @Optional({ nullable: true })
+  @Optional()
   @ApiProperty({ type: 'integer', format: 'int64' })
-  defaultStorageQuota!: number | null;
+  defaultStorageQuota?: number;
 
   @ValidateBoolean()
   enabled!: boolean;
diff --git a/server/src/services/auth.service.ts b/server/src/services/auth.service.ts
@@ -300,7 +300,7 @@ export class AuthService extends BaseService {
         name: userName,
         email: profile.email,
         oauthId: profile.sub,
-        quotaSizeInBytes: storageQuota === null ? null : storageQuota * HumanReadableSize.GiB,
+        quotaSizeInBytes: storageQuota === undefined ? null : storageQuota * HumanReadableSize.GiB,
         storageLabel: storageLabel || null,
       });
     }
diff --git a/server/src/services/system-config.service.spec.ts b/server/src/services/system-config.service.spec.ts
@@ -112,7 +112,6 @@ const updatedConfig = Object.freeze<SystemConfig>({
     buttonText: 'Login with OAuth',
     clientId: '',
     clientSecret: '',
-    defaultStorageQuota: null,
     enabled: false,
     issuerUrl: '',
     mobileOverrideEnabled: false,

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,7 @@ export class AuthService extends BaseService {`
`300`	`300`	`name: userName,`
`301`	`301`	`email: profile.email,`
`302`	`302`	`oauthId: profile.sub,`
`303`		`- quotaSizeInBytes: storageQuota === null ? null : storageQuota * HumanReadableSize.GiB,`
	`303`	`+ quotaSizeInBytes: storageQuota === undefined ? null : storageQuota * HumanReadableSize.GiB,`
`304`	`304`	`storageLabel: storageLabel \|\| null,`
`305`	`305`	`});`
`306`	`306`	`}`