Skip to content

Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter #30422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnbm opened this issue May 25, 2025 · 1 comment
Labels
help wanted a good issue for the community ionfw-internship-2025 type: feature request a new feature, enhancement, or improvement

Comments

@gnbm
Copy link
Contributor

gnbm commented May 25, 2025

Currently, any time ion-toolbar changes in appearance, a lot of screenshots have to be updated.
Most of them are only being updated because they include ion-toolbar for labeling the test; the change in them doesn’t matter because the test isn’t meant to verify the look of the toolbar.

The following groups of tests should be updated so that the test does not include the toolbar, since it doesn’t make sense to test the toolbar as part of the screenshot test in them:

  • badge-basic
  • button
  • item
  • list-header
  • progress-bar
  • searchbar
  • toast
  • toggle

Some of these might have one or two tests where ion-toolbar is used in the component they’re testing, but most of them do not, and all of the components listed here have tests that need to be updated to be refocused so they don’t include the ion-toolbar in the screenshot capture.

@gnbm gnbm added help wanted a good issue for the community type: feature request a new feature, enhancement, or improvement ionfw-internship-2025 labels May 25, 2025
Copy link

ionitron-bot bot commented May 25, 2025

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.

For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted a good issue for the community ionfw-internship-2025 type: feature request a new feature, enhancement, or improvement
Projects
Development

No branches or pull requests

1 participant