App.js useEffect dependency may cause duplicate downloads

[coderabbitai]

Problem Description

In App.js, there's a potential issue with how downloads are processed. The current implementation uses a useEffect hook that depends on downloadStore.downloads.size, which could trigger multiple download attempts for the same file.

useEffect(() => {
  const downloadFile = async (download) => {
    // Download implementation...
  };

  downloadStore.downloads
    .forEach(download => {
      if (!download.isComplete && !download.isDownloading) {
        downloadFile(download);
      }
    });
}, [ rootStore.deviceId, downloadStore.downloads.size ]);

Any time downloads.size changes, the effect runs again and tries to start a download for every incomplete download. If multiple downloads are added at once, or if the download state changes during processing, this can lead to duplicate download attempts for the same file.

Suggested Solutions

1. Track active downloads with useRef:

2. Move download logic to the store:
   Move the download management logic into the downloadStore itself, which can maintain an internal queue and ensure each download is processed exactly once.

This issue was identified during the migration from MobX to Zustand.