Skip to content

Convert application themes to TypeScript #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
coderabbitai bot opened this issue May 22, 2025 · 1 comment
Open
4 tasks

Convert application themes to TypeScript #633

coderabbitai bot opened this issue May 22, 2025 · 1 comment
Labels
cleanup Cleanup of legacy code or code smells good first issue Good for newcomers typescript PRs or issues relating to TypeScript code
Milestone

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 22, 2025

Description

Currently, the application themes are not properly typed with TypeScript, resulting in the use of any type in places like getTheme() in SettingStore.ts.

This issue is to convert the themes to proper TypeScript interfaces/types to improve type safety throughout the application.

Tasks

  • Create TypeScript interface(s) for themes
  • Convert existing theme definitions to use the new interfaces
  • Update references to themes to use proper typing instead of any
  • Remove the TODO comment in SettingStore.ts

Related

@thornbill thornbill added cleanup Cleanup of legacy code or code smells typescript PRs or issues relating to TypeScript code labels May 22, 2025
@thornbill thornbill added this to the v1.7.0 milestone May 22, 2025
@thornbill thornbill removed their assignment May 22, 2025
@venraij
Copy link

venraij commented May 30, 2025

Would it be helpful if i picked this up? I've got some experience and i think this shouldn't be too hard for me to do.

@thornbill thornbill added the good first issue Good for newcomers label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells good first issue Good for newcomers typescript PRs or issues relating to TypeScript code
Development

No branches or pull requests

2 participants