Skip to content

Support '/' characters in credential IDs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chriskilding opened this issue Jun 22, 2022 · 1 comment
Open

Support '/' characters in credential IDs #115

chriskilding opened this issue Jun 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@chriskilding
Copy link

What feature do you want to see added?

(This is really a question about how Azure Keyvault Plugin behaves at the moment, but depending on the answer it could become a feature request.)

The / (forward slash) character is sometimes used to namespace credentials e.g. staging/foobar or production/foobar. This is more prevalent in cloud secrets manager services, where / is used to mimic folder structures.

Does the Azure Keyvault Plugin support credentials with / in their IDs?

  • If it does, how/where does it urlencode the credential ID for presentation (so that it doesn't break the Jenkins credentials Web UI)?
  • If it does not, should support be added for it?

For comparison, the default (local disk) credentials provider has client side validation that tries to stop you using / in new credentials that you add - only A-Za-z0-9 and _ - . are allowed. But if you bypass this validation, in some scenarios it is able to display credential IDs with / characters just fine.

Upstream changes

No response

@timja
Copy link
Member

timja commented Jun 22, 2022

It would work to use / as a namespace because Azure Key Vault credentials can't have a / in their name:
https://docs.microsoft.com/en-us/azure/key-vault/general/about-keys-secrets-certificates

If that's what your question is about anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants