Skip to content

Allow not evicting pods that belong to unknown controllers #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grosser opened this issue Apr 29, 2025 · 2 comments
Open

Allow not evicting pods that belong to unknown controllers #2178

grosser opened this issue Apr 29, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@grosser
Copy link

grosser commented Apr 29, 2025

Description

What problem are you trying to solve?
We have pods that belong to custom controllers, that should not be considered replaceable.
Atm we have to add "do not disrupt" annotation to them via admission,
but it would be nice to have a feature that protects these pods (either by default or optional)
similar to what cluster-autoscaler does with --skip-nodes-with-custom-controller-pods (docs) which is default true

How important is this feature to you?
Not a dealbreaker, but surprising when switching from cluster-autoscaler

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@grosser grosser added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 29, 2025
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Apr 29, 2025
@jmdeal
Copy link
Member

jmdeal commented May 1, 2025

Can you elaborate on what it means for a pod to be owned by a custom controller? Does this mean the pod has an owner-reference for something other than a replica or daemonset?

/triage needs-information

@k8s-ci-robot k8s-ci-robot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 1, 2025
@grosser
Copy link
Author

grosser commented May 1, 2025

For example we have an operator that creates "user consoles" that users will exec into to run tasks,
they will be owned by the operator and should not be interrupted.
In general I think it makes sense to not assume that every pod owned by a unknown controller is replaceable (or at least make it an option).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants