Skip to content

๐Ÿ’„ style: Update GitHub models #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2025
Merged

๐Ÿ’„ style: Update GitHub models #8002

merged 5 commits into from
May 29, 2025

Conversation

chai-mi
Copy link
Contributor

@chai-mi chai-mi commented May 29, 2025

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  1. ไธบ GitHub Model ๆทปๅŠ  grok-3 ๅ’Œ grok-3-mini
  2. ไฟฎๆ”น GitHub Model ็š„ endpoint ๏ผˆ็”ฑไบŽ grok-3 ๅ’Œ grok-3-mini ๅœจๆ—ง endpoint ไธ่ขซๆไพ›๏ผ‰
  3. ไฟฎๆญฃ modelId ๏ผˆ็”ฑไบŽๆ–ฐ endpoint ไฝฟ็”จไธๅŒ็š„ id๏ผ‰
  4. ๅˆ ้™ค grok-3-mini ็š„ presence_penalty frequency_penalty ๅญ—ๆฎต๏ผŒ่ง ๐Ÿ› fix: fix grok-3-mini series callingย #7371

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Copy link

vercel bot commented May 29, 2025

@chai-mi is attempting to deploy a commit to the LobeHub Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 29, 2025
@lobehubbot
Copy link
Member

๐Ÿ‘ @chai-mi

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ label May 29, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates GitHub models integration in LobeChat to support new models and fix compatibility issues.

  • Changed base URL from models.inference.ai.azure.com to models.github.ai/inference to support newer models like grok-3 and grok-3-mini
  • Added special payload handling in /src/libs/model-runtime/github/index.ts to remove unsupported parameters for grok-3-mini model
  • Updated model IDs in /src/config/aiModels/github.ts to include provider namespaces (e.g., openai/, microsoft/)
  • Added grok-3-mini to reasoning keywords list for better model capability detection
  • Fixed issue ๐Ÿ› fix: fix grok-3-mini series callingย #7371 by removing presence_penalty and frequency_penalty parameters for grok-3-mini series

๐Ÿ’ก (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 29 to 34
if (model === 'xai/grok-3-mini') {
return {
...rest,
model,
};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Special case for grok-3-mini should also handle grok-3 model since they're in the same series

@@ -43,7 +50,7 @@ export const LobeGithubAI = LobeOpenAICompatibleFactory({

const visionKeywords = ['vision'];

const reasoningKeywords = ['deepseek-r1', 'o1', 'o3'];
const reasoningKeywords = ['deepseek-r1', 'o1', 'o3', 'grok-3-mini'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding 'grok-3' to reasoningKeywords since it's part of the same model series as grok-3-mini

@arvinxx
Copy link
Contributor

arvinxx commented May 29, 2025

ci ๆŒ‚ไบ†๏ผŒ็œ‹ไธ‹ test

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


ci has died, check out the test

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.44%. Comparing base (ed2ce8d) to head (2f05299).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/libs/model-runtime/github/index.ts 40.00% 3 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8002      +/-   ##
==========================================
- Coverage   95.67%   88.44%   -7.23%     
==========================================
  Files          14      822     +808     
  Lines        2519    60362   +57843     
  Branches      244     3807    +3563     
==========================================
+ Hits         2410    53390   +50980     
- Misses        109     6972    +6863     
Flag Coverage ฮ”
app 88.44% <95.00%> (?)
server 95.67% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chai-mi and others added 2 commits May 29, 2025 18:38
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback May 29, 2025 1:33pm

@arvinxx arvinxx merged commit 7b8f533 into lobehub:main May 29, 2025
17 of 18 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @chai-mi โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request May 29, 2025
### [Version&nbsp;1.88.16](v1.88.15...v1.88.16)
<sup>Released on **2025-05-29**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Cmd + click chat tab not open new tab.

#### ๐Ÿ’„ Styles

- **misc**: Update GitHub models.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Cmd + click chat tab not open new tab, closes [#8001](#8001) ([d6d2129](d6d2129))

#### Styles

* **misc**: Update GitHub models, closes [#8002](#8002) ([7b8f533](7b8f533))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.88.16 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

@SAnBlog
Copy link

SAnBlog commented May 30, 2025

GITHUB_MODEL_LIST=+xai/grok-3=Grok 3<8000>,+xai/grok-3-mini=Grok 3 mini<8000> ๅนถๆฒกๆœ‰ๆ˜พ็คบgrok็š„ๅ›พๆ ‡

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


GITHUB_MODEL_LIST=+xai/grok-3=Grok 3<8000>,+xai/grok-3-mini=Grok 3 mini<8000> does not display grok icon

1 similar comment
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


GITHUB_MODEL_LIST=+xai/grok-3=Grok 3<8000>,+xai/grok-3-mini=Grok 3 mini<8000> does not display grok icon

github-actions bot pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request May 30, 2025
### [Version&nbsp;1.87.1](v1.87.0...v1.87.1)
<sup>Released on **2025-05-30**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Close historySummary correctly, cmd + click chat tab not open new tab, Enable thinking output only for supported Gemini thinking models.

#### ๐Ÿ’„ Styles

- **misc**: Add fc ability to deepseek-reasoner model, increase the history limit, Update GitHub models.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Close historySummary correctly, closes [lobehub#7010](https://github.com/jaworldwideorg/OneJA-Bot/issues/7010) ([90a6f68](90a6f68))
* **misc**: Cmd + click chat tab not open new tab, closes [lobehub#8001](https://github.com/jaworldwideorg/OneJA-Bot/issues/8001) ([d6d2129](d6d2129))
* **misc**: Enable thinking output only for supported Gemini thinking models, closes [lobehub#7987](https://github.com/jaworldwideorg/OneJA-Bot/issues/7987) ([f503c53](f503c53))

#### Styles

* **misc**: Add fc ability to deepseek-reasoner model, closes [lobehub#8006](https://github.com/jaworldwideorg/OneJA-Bot/issues/8006) ([1511c75](1511c75))
* **misc**: Increase the history limit, closes [lobehub#8007](https://github.com/jaworldwideorg/OneJA-Bot/issues/8007) ([5ec7c8d](5ec7c8d))
* **misc**: Update GitHub models, closes [lobehub#8002](https://github.com/jaworldwideorg/OneJA-Bot/issues/8002) ([7b8f533](7b8f533))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants