Skip to content

Commit 219eae8

Browse files
authored
fix: add more presentation attributes to SVG (#2687)
1 parent abe1033 commit 219eae8

File tree

8 files changed

+36
-38
lines changed

8 files changed

+36
-38
lines changed

.changeset/happy-toes-beam.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@marko/runtime-tags": patch
3+
---
4+
5+
Correct SVG types

.sizes.json

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
{
88
"name": "*",
99
"total": {
10-
"min": 19073,
11-
"brotli": 7240
10+
"min": 19069,
11+
"brotli": 7258
1212
}
1313
},
1414
{
@@ -18,57 +18,57 @@
1818
"brotli": 145
1919
},
2020
"runtime": {
21-
"min": 3892,
22-
"brotli": 1730
21+
"min": 3886,
22+
"brotli": 1718
2323
},
2424
"total": {
25-
"min": 4082,
26-
"brotli": 1875
25+
"min": 4076,
26+
"brotli": 1863
2727
}
2828
},
2929
{
3030
"name": "counter 💧",
3131
"user": {
3232
"min": 112,
33-
"brotli": 100
33+
"brotli": 98
3434
},
3535
"runtime": {
36-
"min": 2188,
37-
"brotli": 1157
36+
"min": 2180,
37+
"brotli": 1142
3838
},
3939
"total": {
40-
"min": 2300,
41-
"brotli": 1257
40+
"min": 2292,
41+
"brotli": 1240
4242
}
4343
},
4444
{
4545
"name": "comments",
4646
"user": {
47-
"min": 915,
48-
"brotli": 464
47+
"min": 917,
48+
"brotli": 458
4949
},
5050
"runtime": {
51-
"min": 6958,
52-
"brotli": 2980
51+
"min": 6953,
52+
"brotli": 2970
5353
},
5454
"total": {
55-
"min": 7873,
56-
"brotli": 3444
55+
"min": 7870,
56+
"brotli": 3428
5757
}
5858
},
5959
{
6060
"name": "comments 💧",
6161
"user": {
62-
"min": 145,
63-
"brotli": 128
62+
"min": 146,
63+
"brotli": 119
6464
},
6565
"runtime": {
66-
"min": 2354,
67-
"brotli": 1199
66+
"min": 2347,
67+
"brotli": 1196
6868
},
6969
"total": {
70-
"min": 2499,
71-
"brotli": 1327
70+
"min": 2493,
71+
"brotli": 1315
7272
}
7373
}
7474
]

.sizes/comments.csr/entry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// size: 915 (min) 464 (brotli)
1+
// size: 917 (min) 458 (brotli)
22
const $setup$if$content = ($scope) => {
33
$scope[0], $comment_comments$if$content._($scope), $id$if$content._($scope);
44
},

.sizes/comments.ssr/entry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// size: 145 (min) 128 (brotli)
1+
// size: 146 (min) 119 (brotli)
22
const $open$for$content_effect = effect("a0", ($scope, { 12: open }) =>
33
on($scope[2], "click", function () {
44
$open$for$content($scope, !open);

.sizes/counter.ssr/entry.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// size: 112 (min) 100 (brotli)
1+
// size: 112 (min) 98 (brotli)
22
const $clickCount_effect = effect("a0", ($scope, { 2: clickCount }) =>
33
on($scope[0], "click", function () {
44
$clickCount($scope, clickCount + 1);

.sizes/dom.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// size: 19073 (min) 7240 (brotli)
1+
// size: 19069 (min) 7258 (brotli)
22
var empty = [],
33
rest = Symbol();
44
function attrTag(attrs2) {

.sizes/name-cache.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"vars":{"props":{"$empty":"e","$rest":"t","$attrTag":"n","$attrTags":"r","$attrTagIterator":"l","$forIn":"o","$forOf":"i","$forTo":"u","$stringifyClassObject":"f","$stringifyStyleObject":"a","$toDelimitedString":"c","$isEventHandler":"s","$getEventHandlerName":"d","$normalizeDynamicRenderer":"h","$defaultDelegator":"g","$on":"p","$createDelegator":"v","$handleDelegated":"b","$stripSpacesAndPunctuation":"m","$isResuming":"y","$registeredValues":"k","$init":"w","$register":"C","$registerBoundSignal":"N","$nodeRef":"S","$controllable_input_checked":"A","$controllable_input_checked_effect":"x","$controllable_input_checkedValue":"_","$controllable_input_checkedValue_effect":"$","$controllable_input_value":"I","$controllable_input_value_effect":"M","$controllable_select_value":"j","$controllable_select_value_effect":"E","$setSelectOptions":"T","$controllable_detailsOrDialog_open":"R","$controllable_detailsOrDialog_open_effect":"q","$inputType":"B","$setValueAndUpdateSelection":"L","$setCheckboxValue":"O","$controllableDelegate":"D","$syncControllable":"V","$handleChange":"F","$handleFormReset":"U","$hasValueChanged":"W","$hasCheckboxChanged":"z","$hasSelectChanged":"G","$hasFormElementChanged":"P","$normalizeStrProp":"H","$normalizeBoolProp":"J","$toValueProp":"K","$parsers":"X","$parseHTML":"Z","$attr":"Q","$setAttribute":"Y","$classAttr":"ee","$styleAttr":"te","$data":"ne","$textContent":"re","$attrs":"le","$hasAttrAlias":"oe","$partialAttrs":"ie","$attrsInternal":"ue","$attrsEvents":"fe","$html":"ae","$props":"ce","$normalizeAttrValue":"se","$normalizeString":"de","$lifecycle":"he","$removeChildNodes":"ge","$insertChildNodes":"pe","$toInsertNode":"ve","$pendingScopes":"be","$createScope":"me","$skipScope":"ye","$findBranchWithKey":"ke","$destroyBranch":"we","$destroyNestedBranches":"Ce","$removeAndDestroyBranch":"Ne","$insertBranchBefore":"Se","$tempDetachBranch":"Ae","$walker":"xe","$walk":"_e","$walkInternal":"$e","$createBranch":"Ie","$createAndSetupBranch":"Me","$setupBranch":"je","$createContent":"Ee","$registerContent":"Te","$createRenderer":"Re","$isScheduled":"qe","$cloneCache":"Be","$port2":"Le","$schedule":"Oe","$flushAndWaitFrame":"De","$triggerMacroTask":"Ve","$state":"Fe","$value":"Ue","$intersection":"We","$loopClosure":"ze","$conditionalClosure":"Ge","$subscribeToScopeSet":"Pe","$dynamicClosure":"He","$dynamicClosureRead":"Je","$closure":"Ke","$setTagVar":"Xe","$tagVarSignal":"Ze","$setTagVarChange":"Qe","$tagVarSignalChange":"Ye","$tagIdsByGlobal":"et","$nextTagId":"tt","$effect":"nt","$traverseAllHoisted":"rt","$hoist":"lt","$awaitTag":"ot","$createTry":"it","$renderCatch":"ut","$conditional":"ft","$dynamicTag":"at","$setConditionalRenderer":"ct","$loopOf":"st","$loopIn":"dt","$loopTo":"ht","$loop":"gt","$createBranchWithTagNameOrRenderer":"pt","$bySecondArg":"vt","$byFirstArg":"bt","$rendering":"mt","$pendingRenders":"yt","$pendingRendersLookup":"kt","$caughtError":"wt","$placeholderShown":"Ct","$pendingEffects":"Nt","$scopeKeyOffset":"St","$queueRender":"At","$queueEffect":"xt","$run":"_t","$prepareEffects":"$t","$runEffects":"It","$runRenders":"Mt","$runRender":"jt","$enableCatch":"Et","$resetAbortSignal":"Tt","$getAbortSignal":"Rt","$abort":"qt","$classIdToBranch":"Bt","$compat":"Lt","$createTemplate":"Ot","$mount":"Dt","$$clickCount_effect":"Jt","$$clickCount":"Wt","$$setup":"zt","$$expr_comment_comments_id$if$content":"ss","$$id$if$content":"ts","$$comment_comments$if$content":"as","$$if_content":"ns","$$expr_input_path_i$for$content":"os","$$if$for$content":"cs","$$open$for$content_effect":"ms","$$open$for$content":"is","$$id$for$content":"ls","$$i$for$content":"us","$$comment_comments$for$content":"es","$$comment_text$for$content":"bs","$$comment$for$content":"ps","$$params2$for$content":"hs","$$input_path$for$content":"_s","$$for":"ds","$$input_path":"fs","$$input_comments":"rs","$$input$1":"Cs","$normalizeStyleProperty":"Vt","$classItem":"Ft","$styleItem":"Ut","$styleItemWithPx":"Pt","$styleItemValue":"Gt","$classItems":"Ht","$styleItems":"Kt","$classValue":"Xt","$styleValue":"Zt","$mapAndJoin":"Qt","$updateList":"Yt","$port1":"en","$channel":"tn","$afterMacroTask":"nn","$onMessage":"rn","$branchesEnabled":"ln","$enableBranches":"on","$$setup$if$content":"Ds","$$setup$for$content":"$s","$localClosure":"un","$localClosureValue":"fn","$localClosures":"an"}}}
1+
{"vars":{"props":{"$empty":"e","$rest":"t","$attrTag":"n","$attrTags":"r","$attrTagIterator":"l","$forIn":"o","$forOf":"i","$forTo":"u","$stringifyClassObject":"f","$stringifyStyleObject":"a","$toDelimitedString":"c","$isEventHandler":"s","$getEventHandlerName":"d","$normalizeDynamicRenderer":"h","$defaultDelegator":"g","$on":"p","$createDelegator":"v","$handleDelegated":"b","$stripSpacesAndPunctuation":"m","$branchesEnabled":"y","$isResuming":"k","$registeredValues":"C","$enableBranches":"N","$init":"w","$register":"A","$registerBoundSignal":"S","$nodeRef":"x","$controllable_input_checked":"_","$controllable_input_checked_effect":"M","$controllable_input_checkedValue":"I","$controllable_input_checkedValue_effect":"$","$controllable_input_value":"j","$controllable_input_value_effect":"E","$controllable_select_value":"T","$controllable_select_value_effect":"L","$setSelectOptions":"O","$controllable_detailsOrDialog_open":"R","$controllable_detailsOrDialog_open_effect":"q","$inputType":"B","$setValueAndUpdateSelection":"D","$setCheckboxValue":"V","$controllableDelegate":"F","$syncControllable":"U","$handleChange":"W","$handleFormReset":"P","$hasValueChanged":"z","$hasCheckboxChanged":"G","$hasSelectChanged":"H","$hasFormElementChanged":"J","$normalizeStrProp":"K","$normalizeBoolProp":"X","$toValueProp":"Z","$isScheduled":"Q","$channel":"Y","$parsers":"ee","$parseHTML":"te","$attr":"ne","$setAttribute":"re","$classAttr":"le","$classItems":"oe","$classItem":"ie","$styleAttr":"ue","$styleItems":"fe","$styleItem":"ae","$data":"ce","$textContent":"se","$attrs":"de","$hasAttrAlias":"he","$partialAttrs":"ge","$attrsInternal":"pe","$attrsEvents":"ve","$html":"be","$props":"me","$normalizeAttrValue":"ye","$normalizeString":"ke","$lifecycle":"Ce","$removeChildNodes":"Ne","$insertChildNodes":"we","$toInsertNode":"Ae","$createScope":"Se","$skipScope":"xe","$findBranchWithKey":"_e","$destroyBranch":"Me","$destroyNestedBranches":"Ie","$removeAndDestroyBranch":"$e","$insertBranchBefore":"je","$tempDetachBranch":"Ee","$schedule":"Te","$flushAndWaitFrame":"Le","$triggerMacroTask":"Oe","$state":"Re","$value":"qe","$intersection":"Be","$loopClosure":"De","$conditionalClosure":"Ve","$subscribeToScopeSet":"Fe","$dynamicClosure":"Ue","$dynamicClosureRead":"We","$closure":"Pe","$setTagVar":"ze","$tagVarSignal":"Ge","$setTagVarChange":"He","$tagVarSignalChange":"Je","$tagIdsByGlobal":"Ke","$nextTagId":"Xe","$effect":"Ze","$traverseAllHoisted":"Qe","$hoist":"Ye","$walker":"et","$walk":"tt","$walkInternal":"nt","$createBranch":"rt","$createAndSetupBranch":"lt","$setupBranch":"ot","$createContent":"it","$registerContent":"ut","$localClosures":"ft","$createRenderer":"at","$cloneCache":"ct","$awaitTag":"st","$createTry":"dt","$renderCatch":"ht","$conditional":"gt","$dynamicTag":"pt","$setConditionalRenderer":"vt","$loopOf":"bt","$loopIn":"mt","$loopTo":"yt","$loop":"kt","$createBranchWithTagNameOrRenderer":"Ct","$bySecondArg":"Nt","$byFirstArg":"wt","$rendering":"At","$pendingRenders":"St","$pendingRendersLookup":"xt","$caughtError":"_t","$placeholderShown":"Mt","$pendingEffects":"It","$pendingScopes":"$t","$scopeKeyOffset":"jt","$queueRender":"Et","$queueEffect":"Tt","$run":"Lt","$prepareEffects":"Ot","$runEffects":"Rt","$runRenders":"qt","$runRender":"Bt","$enableCatch":"Dt","$resetAbortSignal":"Vt","$getAbortSignal":"Ft","$abort":"Ut","$classIdToBranch":"Wt","$compat":"Pt","$createTemplate":"zt","$mount":"Gt","$$clickCount_effect":"Zt","$$clickCount":"Ht","$$setup":"Jt","$$setup$if$content":"ss","$$expr_comment_comments_id$if$content":"ts","$$comment_comments$if$content":"as","$$id$if$content":"ns","$$if_content":"os","$$id$for$content":"cs","$$expr_input_path_i$for$content":"ms","$$input_path$for$content":"is","$$i$for$content":"ls","$$open$for$content_effect":"us","$$open$for$content":"es","$$setup$for$content":"bs","$$comment_text$for$content":"ps","$$if$for$content":"hs","$$comment_comments$for$content":"_s","$$params2$for$content":"ds","$$comment$for$content":"fs","$$for":"rs","$$input_comments":"gs","$$input$1":"$s","$$input_path":"js"}}}

packages/runtime-tags/tags-html.d.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2653,11 +2653,6 @@ declare global {
26532653
*/
26542654
externalResourcesRequired?: AttrBooleanString;
26552655

2656-
/**
2657-
* @see https://www.w3.org/TR/2011/REC-SVG11-20110816/coords.html#TransformAttribute
2658-
*/
2659-
transform?: AttrString;
2660-
26612656
/**
26622657
* @see https://www.w3.org/TR/css-masking-1/#element-attrdef-clippath-clippathunits
26632658
*/
@@ -3822,11 +3817,6 @@ declare global {
38223817
*/
38233818
zoomAndPan?: AttrMissing | "disable" | "magnify";
38243819

3825-
/**
3826-
* @see https://www.w3.org/TR/SVG2/coords.html#TransformProperty
3827-
*/
3828-
transform?: AttrString;
3829-
38303820
/**
38313821
* @see https://www.w3.org/TR/SVG2/geometry.html#XProperty
38323822
*/
@@ -4476,6 +4466,7 @@ declare global {
44764466
mask?: AttrMissing | csstype.Property.Mask;
44774467
opacity?: AttrMissing | csstype.Property.Opacity | number;
44784468
overflow?: AttrMissing | csstype.Property.Overflow;
4469+
"paint-order"?: AttrMissing | csstype.Property.PaintOrder;
44794470
"pointer-events"?: AttrMissing | csstype.Property.PointerEvents;
44804471
"shape-rendering"?: AttrMissing | csstype.Property.ShapeRendering;
44814472
"stop-color"?: AttrMissing | csstype.Property.StopColor;
@@ -4500,7 +4491,9 @@ declare global {
45004491
"text-anchor"?: AttrMissing | csstype.Property.TextAnchor;
45014492
"text-decoration"?: AttrMissing | csstype.Property.TextDecoration;
45024493
"text-rendering"?: AttrMissing | csstype.Property.TextRendering;
4494+
transform?: AttrMissing | csstype.Property.Transform;
45034495
"unicode-bidi"?: AttrMissing | csstype.Property.UnicodeBidi;
4496+
"vector-effect"?: AttrMissing | csstype.Property.VectorEffect;
45044497
visibility?: AttrMissing | csstype.Property.Visibility;
45054498
"word-spacing"?: AttrMissing | csstype.Property.WordSpacing | number;
45064499
"writing-mode"?: AttrMissing | csstype.Property.WritingMode;

0 commit comments

Comments
 (0)