Skip to content

Remove JsonEncodingException & JsonDecodingException #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stloyd opened this issue Jun 7, 2023 · 1 comment · May be fixed by #759
Open

Remove JsonEncodingException & JsonDecodingException #526

stloyd opened this issue Jun 7, 2023 · 1 comment · May be fixed by #759
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request good first issue Good for newcomers

Comments

@stloyd
Copy link
Contributor

stloyd commented Jun 7, 2023

There is no point in adding an additional layer with JsonEncodingException & JsonDecodingException over the exceptions thrown by the PHP itself.
@brunoocasali brunoocasali added enhancement New feature or request breaking-change The related changes are breaking for the users labels Jul 11, 2023
@norkunas
Copy link
Collaborator

Additionally given that there is PSR18 we also don't need Meilisearch\Contracts\Http

@Strift Strift mentioned this issue May 23, 2025
Open
3 tasks
@Strift Strift added the good first issue Good for newcomers label May 23, 2025
@Strift Strift linked a pull request May 30, 2025 that will close this issue
Open
3 tasks
@Strift Strift linked a pull request May 30, 2025 that will close this issue
Remove custom JSON exceptions #759
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove custom JSON exceptions meilisearch/meilisearch-php
4 participants
@stloyd @norkunas @brunoocasali @Strift