fix(timeline): ensure consistent vertical line lengths with visible arrowheads #6616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrowheads - Fixed inconsistent vertical line lengths in timeline diagrams - All vertical lines now extend to same depth regardless of event count - Added sufficient padding for clear visibility of dashed lines and arrowheads - Added comprehensive test case and demo example Fixes #6610
🦋 Changeset detectedLatest commit: ca80f71 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
Type: Bug / Error
mermaid
@mermaid-js/mermaid-zenuml
@mermaid-js/layout-elk
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6616 +/- ##
=======================================
Coverage 3.87% 3.87%
=======================================
Files 414 414
Lines 43303 43300 -3
Branches 666 666
=======================================
Hits 1679 1679
+ Misses 41624 41621 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ashishjain0512
changed the title
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6610 - Timeline vertical lines now have consistent lengths with clearly visible arrowheads.
Changes
maxEventLineLengthcalculation to include proper event spacingBefore/After
Before: Vertical lines had inconsistent lengths, arrowheads were barely visible
After: All vertical lines extend to same depth with clear dashed lines and full arrowheads
Testing
timeline.spec.tsdemos/timeline.htmlwith complex exampleResolves #6610
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.