Skip to content

🌱 enable errorlint linter and fix lints #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 enable errorlint linter and fix lints #2440

wants to merge 1 commit into from

Conversation

tylerauerbeck
Copy link
Contributor

What this PR does / why we need it: This enables the the errorlint linter in golangcilint and addresses the lints that were triggered by it. This mostly converts type assertions to use errors.As checks. Per Go doc recommendations, this moved a number of type switches to a series of if statements.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2354

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2025
@metal3-io-bot
Copy link
Contributor

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2025
@tuminoid
Copy link
Member

tuminoid commented May 7, 2025

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2025
tuminoid
tuminoid reviewed May 7, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please fix the issues reported by CI and squash the commits.

/cc @lentzi90
PTAL.

@metal3-io-bot metal3-io-bot requested a review from lentzi90 May 7, 2025 09:32
lentzi90
lentzi90 reviewed May 7, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! As @tuminoid said, please fix the linter issue (just change v to w from what I understand) and also please squash the commits into one.

@tylerauerbeck tylerauerbeck force-pushed the add-errorlint-linter branch from 8a7ff2e to 3f64c51 Compare May 8, 2025 05:03
@tylerauerbeck tylerauerbeck force-pushed the add-errorlint-linter branch from 3f64c51 to e4f751c Compare May 8, 2025 05:05
@tylerauerbeck
Copy link
Contributor Author

/retest

@metal3-io-bot
Copy link
Contributor

@tylerauerbeck: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test e4f751c link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable "errorlint" linter in golangci-lint
4 participants
@tylerauerbeck @metal3-io-bot @tuminoid @lentzi90